Skip to content

London|ITP-January-2026|Alexandru Pocovnicu|Sprint 2|Form controls#943

Open
alexandru-pocovnicu wants to merge 14 commits intoCodeYourFuture:mainfrom
alexandru-pocovnicu:form-controls
Open

London|ITP-January-2026|Alexandru Pocovnicu|Sprint 2|Form controls#943
alexandru-pocovnicu wants to merge 14 commits intoCodeYourFuture:mainfrom
alexandru-pocovnicu:form-controls

Conversation

@alexandru-pocovnicu
Copy link
Copy Markdown

@alexandru-pocovnicu alexandru-pocovnicu commented Jan 12, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Created a fill out form using only HTML

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 12, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 48f9c7a
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/69711c921d74a3000802fc7d
😎 Deploy Preview https://deploy-preview-943--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@alexandru-pocovnicu alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 12, 2026
@jenny-alexander jenny-alexander self-requested a review January 19, 2026 23:19
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 19, 2026
jenny-alexander
jenny-alexander reviewed Jan 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jenny-alexander jenny-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did some very good work in this PR @alexandru-pocovnicu! I added a few comments for you to review.

  • I am unsure of the use of &nbsp. Is this for formatting/styling purposes? I would avoid using this for a number of reasons: screen reader might announce each &nbsp as a space and pause; it's hard for future developers to maintain; it's breaks responsive layouts.

Comment thread Form-Controls/index.html Outdated
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
<h3>By Alexandru Pocovnicu</h3>
Copy link
Copy Markdown
Contributor

@jenny-alexander jenny-alexander Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 You might consider using a different HTML element for your name within the footer. Right now, having <h3> in the footer will signal to screen readers that there is something new and important in the footer (like a sub-topic). In a sense, it breaks the semantic order of the page.

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 20, 2026
@alexandru-pocovnicu
Copy link
Copy Markdown
Author

alexandru-pocovnicu commented Jan 20, 2026

Thank you, I have added them in to a table, is there any other way of adding white space?

@alexandru-pocovnicu alexandru-pocovnicu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 20, 2026
@jenny-alexander
Copy link
Copy Markdown
Contributor

jenny-alexander commented Jan 21, 2026

Thank you, I have added them in to a table, is there any other way of adding white space?

I wouldn't worry too much about the alignment and spacing in the exercise! 🙂
Since the exercise says not to use CSS, I think it's okay to leave it somewhat unstyled. The point of the exercise is to focus on understanding how to add validation to a form.
FYI: I discourage using <table> for styling purposes. Using a <table> tells the browser and screen readers that you are trying to display tabular data (like in a spreadsheet).

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 21, 2026
@alexandru-pocovnicu alexandru-pocovnicu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 21, 2026
@alexandru-pocovnicu
Copy link
Copy Markdown
Author

alexandru-pocovnicu commented Jan 21, 2026

done

jenny-alexander
jenny-alexander reviewed Jan 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jenny-alexander jenny-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @alexandru-pocovnicu

@jenny-alexander jenny-alexander added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 21, 2026
@alexandru-pocovnicu
Copy link
Copy Markdown
Author

alexandru-pocovnicu commented Jan 21, 2026

thank you

@alexandru-pocovnicu alexandru-pocovnicu mentioned this pull request Jan 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jenny-alexander jenny-alexander jenny-alexander left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexandru-pocovnicu @jenny-alexander