Skip to content

Commit a96e512

Browse files
CodeGhost21claude
andcommitted
ci: run macOS and Windows E2E jobs on pull_request events
Both e2e-macos and e2e-windows were only triggered on push to main or manual workflow_dispatch, causing them to be skipped on PRs. Add pull_request as a trigger condition for both jobs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 8304dda commit a96e512

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

.github/workflows/test.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -217,11 +217,11 @@ jobs:
217217
218218
e2e-macos:
219219
name: E2E (macOS / Appium Mac2)
220-
# Run on manual dispatch with opt-in flag, or on pushes to main.
221-
# macOS runners are ~10× more expensive than Linux — keep gated by default.
220+
# Run on: PRs, pushes to main, or manual dispatch with opt-in flag.
222221
if: >
223-
github.event_name == 'workflow_dispatch' && github.event.inputs.run_macos_e2e == 'true' ||
224-
github.event_name == 'push' && github.ref == 'refs/heads/main'
222+
github.event_name == 'pull_request' ||
223+
github.event_name == 'push' && github.ref == 'refs/heads/main' ||
224+
github.event_name == 'workflow_dispatch' && github.event.inputs.run_macos_e2e == 'true'
225225
runs-on: macos-latest
226226
timeout-minutes: 90
227227
steps:
@@ -320,11 +320,12 @@ jobs:
320320

321321
e2e-windows:
322322
name: E2E (Windows / tauri-driver)
323-
# Run on manual dispatch (same flag as macOS) or pushes to main.
323+
# Run on: PRs, pushes to main, or manual dispatch with opt-in flag.
324324
# windows-latest runners are ~2× more expensive than Linux.
325325
if: >
326-
github.event_name == 'workflow_dispatch' && github.event.inputs.run_macos_e2e == 'true' ||
327-
github.event_name == 'push' && github.ref == 'refs/heads/main'
326+
github.event_name == 'pull_request' ||
327+
github.event_name == 'push' && github.ref == 'refs/heads/main' ||
328+
github.event_name == 'workflow_dispatch' && github.event.inputs.run_macos_e2e == 'true'
328329
runs-on: windows-latest
329330
timeout-minutes: 60
330331
defaults:

0 commit comments

Comments
 (0)