From 7dbddc6033602506f4fa974d2dceed250322c052 Mon Sep 17 00:00:00 2001
From: Johannes Kissel <johannes.kissel@disy.net>
Date: Sun, 8 Jan 2017 15:51:04 +0100
Subject: [PATCH 1/2] now detecting accessKey modifiers based on userAgent

---
 src/workflowyfx.js | 40 ++++++++++++++++++++++++++++++++++------
 1 file changed, 34 insertions(+), 6 deletions(-)

diff --git a/src/workflowyfx.js b/src/workflowyfx.js
index b618d2e..b596f10 100644
--- a/src/workflowyfx.js
+++ b/src/workflowyfx.js
@@ -45,6 +45,14 @@ $(`<button accesskey="n">`)
 		return false
 	})
 
+var modsHtml;
+var mods = accessKeyModifiers(navigator.userAgent)
+if (mods) {
+	modsHtml = `<kbd>${mods.join('</kbd> + <kbd>')}</kbd> + `
+} else {
+	modsHtml = `<a href="https://developer.mozilla.org/docs/Web/HTML/Global_attributes/accesskey" target="_blank"><em>ACC</em></a> + `
+}
+
 // add it to shortcut list
 afterCommand(`Add a note`).addAccessKey(`Show/hide all notes`, `N`)
 
@@ -88,12 +96,32 @@ function afterRowAddNewCommand($row, name, description) {
 	$row.after(newRow)
 }
 
-function accessKeyText(accessKey) {
-	return accessKeyModifier() + ` + ` + accessKey
+function accessKeyHtml(accessKey) {
+	return (modsHTML + accessKey)
+}
+
+// see https://developer.mozilla.org/docs/Web/HTML/Global_attributes/accesskey
+function accessKeyModifiers(ua) {
+	var uaFlags = parseUserAgent(ua)
+
+	var isKnownPlatform = (uaFlags.lin || uaFlags.mac || uaFlags.win)
+	var isKnownApp = (uaFlags.chrome || uaFlags.firefox)
+	if (! isKnownPlatform || ! isKnownApp) return
+
+	if (uaFlags.mac)     return [ `Ctrl`, `Alt` ]
+	if (uaFlags.chrome)  return [ `Alt` ]
+	if (uaFlags.firefox) return [ `Alt`, `Shift` ]
 }
 
-function accessKeyModifier() {
-	// TODO: determine shortcut according to browser and OS
-	// TODO: memoize
-	return `<a href="https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey" target="_blank">ACC</a>`
+function parseUserAgent(ua) {
+	var uaLower = ua.toLowerCase()
+
+	return {
+		lin: uaLower.indexOf(`lin`) != -1,
+		mac: uaLower.indexOf(`mac`) != -1,
+		win: uaLower.indexOf(`win`) != -1,
+
+		chrome:  uaLower.indexOf(`chrome`)  != -1,
+		firefox: uaLower.indexOf(`firefox`) != -1
+	}
 }

From d6d912e523fbe589ddd0f11e216a9508b3813b2c Mon Sep 17 00:00:00 2001
From: Johannes Kissel <johannes.kissel@disy.net>
Date: Sun, 8 Jan 2017 15:52:40 +0100
Subject: [PATCH 2/2] fixed wrong method call

---
 src/workflowyfx.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/workflowyfx.js b/src/workflowyfx.js
index b596f10..b0acf59 100644
--- a/src/workflowyfx.js
+++ b/src/workflowyfx.js
@@ -82,7 +82,7 @@ function afterCommand(name) {
 			afterRowAddNewCommand($commandRow, name, description)
 		},
 		addAccessKey : function(name, accessKey) {
-			afterRowAddNewCommand($commandRow, name, accessKeyText(accessKey))
+			afterRowAddNewCommand($commandRow, name, accessKeyHtml(accessKey))
 		}
 	}
 }