Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support fish shell #1853

Open
sgruby opened this issue Aug 17, 2024 · 6 comments
Open

✨ Support fish shell #1853

sgruby opened this issue Aug 17, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request terminal

Comments

@sgruby
Copy link

sgruby commented Aug 17, 2024

Description

Currently it appears that only bash and zsh are supported shells. My default shell is fish and I can't use the terminal pane because of it. I modified the code to add fish to my local copy (not with the integration, just to allow it as an option) and it appears to work fine.

Alternatives Considered

No response

Additional Context

No response

Screenshots

No response

@thecoolwinter
Copy link
Collaborator

The big thing to support here is the terminal integration. See this code here. We'll likely need a new integration script, and to add a case to this enum and the Shell enum.

@nis-ship-it
Copy link

@thecoolwinter don't know much about Bundle.main here, could you explain? I'm not able to call the fish shell throws error

https://github.com/CodeEditApp/CodeEdit/pull/1908/files#diff-6aaec9c4526c8226b2f628df417695d65f9d22091b06526cd7d71cf1d35f4896R168-R173

@thecoolwinter
Copy link
Collaborator

@thecoolwinter don't know much about Bundle.main here, could you explain? I'm not able to call the fish shell throws error

https://github.com/CodeEditApp/CodeEdit/pull/1908/files#diff-6aaec9c4526c8226b2f628df417695d65f9d22091b06526cd7d71cf1d35f4896R168-R173

You can drag the file into the same folder as the other shell integration files in Xcode and Xcode will know to copy it into the bundle.

@thecoolwinter
Copy link
Collaborator

It's the ShellIntegration folder.

@nis-ship-it
Copy link

@thecoolwinter don't know much about Bundle.main here, could you explain? I'm not able to call the fish shell throws error
https://github.com/CodeEditApp/CodeEdit/pull/1908/files#diff-6aaec9c4526c8226b2f628df417695d65f9d22091b06526cd7d71cf1d35f4896R168-R173

You can drag the file into the same folder as the other shell integration files in Xcode and Xcode will know to copy it into the bundle.

I meant can we know where we can find it? Like other shell files? Is it in Info.plist?

@nis-ship-it
Copy link

Sorry my bad I found out the folder that you meant, I was dumb... was thinking how you pointing me to the enum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request terminal
Projects
Status: 📋 Todo
Development

No branches or pull requests

3 participants