remove package-global argValues array

sauerbraten · sauerbraten · commit 0e59615c7a6c · 2020-09-22T14:23:01.000+02:00
prevents data races in concurrent use
diff --git a/eval.go b/eval.go
@@ -1258,8 +1258,6 @@ func (st *Runtime) evalPipelineExpression(node *PipeNode) (value reflect.Value,
 	return
 }
 
-var argValues = [24]reflect.Value{}
-
 func (st *Runtime) evaluateArgs(fnType reflect.Type, args CallArgs, pipedArg *reflect.Value) ([]reflect.Value, error) {
 	numArgs := len(args.Exprs)
 	if !args.HasPipeSlot && pipedArg != nil {
@@ -1278,6 +1276,7 @@ func (st *Runtime) evaluateArgs(fnType reflect.Type, args CallArgs, pipedArg *re
 		}
 	}
 
+	argValues := make([]reflect.Value, numArgs)
 	slot := 0 // index in argument values (evaluated expressions combined with piped argument if applicable)
 
 	if !args.HasPipeSlot && pipedArg != nil {
@@ -1325,7 +1324,7 @@ func (st *Runtime) evaluateArgs(fnType reflect.Type, args CallArgs, pipedArg *re
 		}
 	}
 
-	return argValues[:slot], nil
+	return argValues, nil
 }
 
 func isUint(kind reflect.Kind) bool {

Original file line number	Diff line number	Diff line change
`@@ -1258,8 +1258,6 @@ func (st Runtime) evalPipelineExpression(node PipeNode) (value reflect.Value,`
`1258`	`1258`	`return`
`1259`	`1259`	`}`
`1260`	`1260`
`1261`		`-var argValues = [24]reflect.Value{}`
`1262`		`-`
`1263`	`1261`	`func (st Runtime) evaluateArgs(fnType reflect.Type, args CallArgs, pipedArg reflect.Value) ([]reflect.Value, error) {`
`1264`	`1262`	`numArgs := len(args.Exprs)`
`1265`	`1263`	`if !args.HasPipeSlot && pipedArg != nil {`
`@@ -1278,6 +1276,7 @@ func (st Runtime) evaluateArgs(fnType reflect.Type, args CallArgs, pipedArg re`
`1278`	`1276`	`}`
`1279`	`1277`	`}`
`1280`	`1278`
	`1279`	`+ argValues := make([]reflect.Value, numArgs)`
`1281`	`1280`	`slot := 0 // index in argument values (evaluated expressions combined with piped argument if applicable)`
`1282`	`1281`
`1283`	`1282`	`if !args.HasPipeSlot && pipedArg != nil {`
`@@ -1325,7 +1324,7 @@ func (st Runtime) evaluateArgs(fnType reflect.Type, args CallArgs, pipedArg re`
`1325`	`1324`	`}`
`1326`	`1325`	`}`
`1327`	`1326`
`1328`		`- return argValues[:slot], nil`
	`1327`	`+ return argValues, nil`
`1329`	`1328`	`}`
`1330`	`1329`
`1331`	`1330`	`func isUint(kind reflect.Kind) bool {`