Skip to content

Commit 2727d49

Browse files
committed
Not starting Client/ClientCase.Query_ID tests on non-Linux platforms
Since on those we user remote clickhouse server, and it doesn't support 'system.query_log' for unpaind/anonymous users
1 parent 26572c1 commit 2727d49

File tree

3 files changed

+15
-5
lines changed

3 files changed

+15
-5
lines changed

.github/workflows/macos.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ jobs:
6565
working-directory: ${{github.workspace}}/build/ut
6666
env:
6767
# It is impossible to start CH server in docker on macOS due to github actions limitations,
68-
# so limit tests to ones that do no require server interaction.
69-
GTEST_FILTER_ONLY_LOCAL: "-Client/*"
70-
run: ./clickhouse-cpp-ut
68+
# so we use remote server to execute tests, some do not allow some features for anonymoust/free users:
69+
# - system.query_log used by 'Client/ClientCase.Query_ID'
70+
GTEST_FILTER: "-Client/ClientCase.Query_ID*"
71+
run: ./clickhouse-cpp-ut ${GTEST_FILTER}

.github/workflows/windows_mingw.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,12 @@ jobs:
8181
./go-tlsoffloader.exe -l localhost:9000 -b github.demo.trial.altinity.cloud:9440 &
8282
8383
- name: Test
84-
run: ./build/ut/clickhouse-cpp-ut.exe
84+
env:
85+
# It is impossible to start CH server in docker on Windows due to github actions limitations,
86+
# so we use remote server to execute tests, some do not allow some features for anonymoust/free users:
87+
# - system.query_log used by 'Client/ClientCase.Query_ID'
88+
GTEST_FILTER: "-Client/ClientCase.Query_ID*"
89+
run: ./build/ut/clickhouse-cpp-ut.exe ${GTEST_FILTER}
8590

8691
- name: Test (simple)
8792
run: ./build/tests/simple/simple-test.exe

.github/workflows/windows_msvc.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ on:
1010

1111
env:
1212
BUILD_TYPE: Release
13-
GTEST_FILTER: --gtest_filter=-"*"
1413
CLICKHOUSE_USER: clickhouse_cpp_cicd
1514
CLICKHOUSE_PASSWORD: clickhouse_cpp_cicd
1615
#
@@ -58,5 +57,10 @@ jobs:
5857
./go-tlsoffloader.exe -l localhost:9000 -b github.demo.trial.altinity.cloud:9440 &
5958
6059
- name: Test
60+
env:
61+
# It is impossible to start CH server in docker on Windows due to github actions limitations,
62+
# so we use remote server to execute tests, some do not allow some features for anonymoust/free users:
63+
# - system.query_log used by 'Client/ClientCase.Query_ID'
64+
GTEST_FILTER: "-Client/ClientCase.Query_ID*"
6165
working-directory: ${{github.workspace}}/build/ut
6266
run: Release\clickhouse-cpp-ut.exe "${{env.GTEST_FILTER}}"

0 commit comments

Comments
 (0)