Skip to content

Commit a3335fa

Browse files
Chen Zhongjinmarckleinebudde
authored andcommitted
can: af_can: can_exit(): add missing dev_remove_pack() of canxl_packet
In can_init(), dev_add_pack(&canxl_packet) is added but not removed in can_exit(). It breaks the packet handler list and can make kernel panic when can_init() is called for the second time. | > modprobe can && rmmod can | > rmmod xxx && modprobe can | | BUG: unable to handle page fault for address: fffffbfff807d7f4 | RIP: 0010:dev_add_pack+0x133/0x1f0 | Call Trace: | <TASK> | can_init+0xaa/0x1000 [can] | do_one_initcall+0xd3/0x4e0 | ... Fixes: fb08cba ("can: canxl: update CAN infrastructure for CAN XL frames") Signed-off-by: Chen Zhongjin <[email protected]> Acked-by: Oliver Hartkopp <[email protected]> Link: https://lore.kernel.org/all/[email protected] [mkl: adjust subject and commit message] Signed-off-by: Marc Kleine-Budde <[email protected]>
1 parent c23fb2c commit a3335fa

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

net/can/af_can.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -902,6 +902,7 @@ static __init int can_init(void)
902902
static __exit void can_exit(void)
903903
{
904904
/* protocol unregister */
905+
dev_remove_pack(&canxl_packet);
905906
dev_remove_pack(&canfd_packet);
906907
dev_remove_pack(&can_packet);
907908
sock_unregister(PF_CAN);

0 commit comments

Comments
 (0)