Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Error happens in reranking process for TeiFastReranking #549

Closed
tknrych opened this issue Dec 4, 2024 · 0 comments · Fixed by #576
Closed

[BUG] Error happens in reranking process for TeiFastReranking #549

tknrych opened this issue Dec 4, 2024 · 0 comments · Fixed by #576
Labels
bug Something isn't working

Comments

@tknrych
Copy link
Contributor

tknrych commented Dec 4, 2024

Description

When using TeiFastReranking as the reranking method, if a string exceeding the Max Tokens supported by the Reranker Model specified on the TeiFastReranking Server side is passed, the server returns an error. As a result, an error warning would also be displayed on the kotaemon interface. Although the is_truncated option was present in the kotaemon code, no processing was implemented for it. To address this, functionality was added to allow specifying the max_tokens option alongside the is_truncated option. If a string exceeding the specified max_tokens is passed, the string will now be truncated accordingly.

Here is a pull request for just your referece.
https://github.com/Cinnamon/kotaemon/pull/530

Reproduction steps

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Screenshots

![DESCRIPTION](LINK.png)

Logs

No response

Browsers

No response

OS

No response

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant