Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Generic device border #28

Open
Garbee opened this issue Mar 5, 2015 · 3 comments
Open

Generic device border #28

Garbee opened this issue Mar 5, 2015 · 3 comments
Assignees

Comments

@Garbee
Copy link
Contributor

Garbee commented Mar 5, 2015

We should add a generic device border that can be used for devices that don't have device art. This would help with issue #12 since then we don't require device art but use it if available.

@kdzwinel
Copy link
Contributor

kdzwinel commented Mar 5, 2015

I agree that current generic border ({border: black 5px}) is not very beautiful. It should be possilble to create a better one based on provided svgs. If you'd like to take a shot at it then please do!

@Garbee Garbee self-assigned this Mar 5, 2015
@Garbee
Copy link
Contributor Author

Garbee commented Mar 5, 2015

Maybe if we cut the screen off of the chromebook image that would be better in the long run?

I'd like do something simple and ugly, but functional up front so we can start working on import functionality. We can find better border imagery later. I feel getting more devices in sooner to really stress-test is a win over having it look good as it happens.

@Garbee
Copy link
Contributor Author

Garbee commented Mar 5, 2015

actually, cutting the screen wouldn't work 100% since it wouldn't really look right at mobile sizes... But maybe using that bezel style is the way to go. Build CSS or SVG that emulates that look that is scalable for any size.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants