feat: Add advanced dynamic search for package managers - #4955
vyas-devgna wants to merge 31 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 SummarySummary by CodeRabbit
WalkthroughThe change adds package-manager catalog search and dynamic application results. It updates search filtering, manager switching, export behavior, logging, system detection, repair rollback, UI construction, and related tests and documentation. ChangesPackage manager search flow
Application maintenance
Priority: ➖ Normal Estimated code review effort: 5 (Critical) | ~90 minutes Change: Feature · Severity of issue fixed: Medium Sequence Diagram(s)sequenceDiagram
participant User
participant InstallTab
participant FindApps as Find-AppsByNameOrDescription
participant PackageSearch as Find-WinUtilPackageManagerApps
participant Catalog
User->>InstallTab: enter search or switch manager
InstallTab->>FindApps: submit current search and manager
FindApps->>PackageSearch: start tokenized catalog query
PackageSearch->>Catalog: run Winget or Chocolatey search
Catalog-->>PackageSearch: return package rows
PackageSearch-->>FindApps: return normalized results
FindApps-->>InstallTab: render curated and dynamic results
Merge Risk: 🟠 High · up to The current evidence indicates broken tests and several user-facing workflow defects, including an ISO that can remain mounted after failure. These should be resolved before merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Out of Scope Changes checkExplanation The PR also changes behavior unrelated to
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (6)
functions/private/Find-AppsByNameOrDescription.ps1 (2)
329-331: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove the duplicated stale-search check.
Lines 329 and 331 perform the same comparison with no code between them. Delete one of them.
♻️ Proposed fix
if ($sync.LatestPackageManagerSearch -ne $SearchString) { return } - if ($sync.LatestPackageManagerSearch -ne $SearchString) { return } - if ($null -ne $sync.ItemsControl -and $null -ne $sync.ItemsControl.Dispatcher) {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@functions/private/Find-AppsByNameOrDescription.ps1` around lines 329 - 331, Remove the duplicated LatestPackageManagerSearch comparison in the stale-search validation block, keeping a single check that returns when it differs from $SearchString.
55-57: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueThe silent guard removes user feedback on invalid state.
The function now returns without any message when
$sync.ItemsControlor the catalog is missing. The project keeps user-feedback patterns for search actions. Add aWrite-DebugorWrite-Warningcall so a failed Install-tab search is diagnosable from the session log.As per coding guidelines: "Preserve existing logging and user-feedback patterns for long-running or destructive operations."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@functions/private/Find-AppsByNameOrDescription.ps1` around lines 55 - 57, Add diagnostic feedback to the early guard in Find-AppsByNameOrDescription by issuing an appropriate Write-Debug or Write-Warning message before returning when sync state, ItemsControl, configs, or applicationsHashtable is missing. Preserve the existing validation and return behavior, and match the function’s established search-action logging style.Source: Coding guidelines
scripts/main.ps1 (1)
137-148: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueExtract the duplicated refresh logic.
Both handlers contain the same three lines. Move them into a small helper, for example
Update-WinUtilInstallSearchResults, and call it from each handler. This keeps the two package managers in sync when the refresh condition changes.♻️ Proposed refactor
+function Update-WinUtilInstallSearchResults { + if ($sync.currentTab -eq "Install" -and -not [string]::IsNullOrWhiteSpace($sync.SearchBar.Text)) { + Find-AppsByNameOrDescription -SearchString $sync.SearchBar.Text -Category $sync.SearchBar.Tag + } +} + $sync.ChocoRadioButton.Add_Checked({ $sync.preferences.packagemanager = "Choco" - if ($sync.currentTab -eq "Install" -and -not [string]::IsNullOrWhiteSpace($sync.SearchBar.Text)) { - Find-AppsByNameOrDescription -SearchString $sync.SearchBar.Text -Category $sync.SearchBar.Tag - } + Update-WinUtilInstallSearchResults }) $sync.WingetRadioButton.Add_Checked({ $sync.preferences.packagemanager = "Winget" - if ($sync.currentTab -eq "Install" -and -not [string]::IsNullOrWhiteSpace($sync.SearchBar.Text)) { - Find-AppsByNameOrDescription -SearchString $sync.SearchBar.Text -Category $sync.SearchBar.Tag - } + Update-WinUtilInstallSearchResults })🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/main.ps1` around lines 137 - 148, Extract the shared install-search refresh condition and Find-AppsByNameOrDescription call from the ChocoRadioButton and WingetRadioButton handlers into a helper named Update-WinUtilInstallSearchResults, then invoke that helper from both handlers after updating their package manager preference.functions/private/Find-WinUtilPackageManagerApps.ps1 (2)
76-93: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winWinget column split can absorb trailing non-package lines.
Lines after the dash separator can include informational text, for example the truncation notice that winget prints when results exceed the terminal width. Such a line splits into two or more columns and becomes a package entry with an invalid
Id. Add a filter that requires theIdcolumn to contain no whitespace.♻️ Proposed filter
if ($name -and $id) { + if ($id -match '\s') { continue } $results.Add([pscustomobject]@{🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@functions/private/Find-WinUtilPackageManagerApps.ps1` around lines 76 - 93, Update the package-row parsing in Find-WinUtilPackageManagerApps so entries are added only when the trimmed Id contains no whitespace. Apply this validation alongside the existing non-empty Name and Id checks before results.Add, while preserving valid package rows.
40-51: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winNative command failures do not throw, so error output can be parsed as packages.
choco search ... 2>&1merges stderr into$out. A non-zero exit code does not raise an exception, so thecatchblock at Line 96 never runs for CLI failures. Any stderr line that contains|becomes a package entry. Check$LASTEXITCODEafter the call and return an empty array when the command fails.♻️ Proposed guard
$out = @(choco search $SearchString --limit-output 2>&1) + if ($LASTEXITCODE -ne 0) { return ,@() } foreach ($line in $out) {The same check applies to the
winget searchcall at Line 61.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@functions/private/Find-WinUtilPackageManagerApps.ps1` around lines 40 - 51, Update the choco search flow in Find-WinUtilPackageManagerApps by checking $LASTEXITCODE immediately after the command and returning an empty array when it is non-zero, before parsing $out. Apply the same failure guard to the winget search call so native command error output is never treated as package data.pester/search-filter.Tests.ps1 (1)
475-488: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winThe deduplication test can pass without running the package-manager flow.
The assertion only checks that a key is absent. It also passes when
Find-WinUtilPackageManagerAppsis never called, or when the UI update block returns early. AddShould -Invoke Find-WinUtilPackageManagerApps -Times 1and a companion test where a non-curated result creates the dynamic entry. The positive test proves that dynamic entry creation works and gives the negative test meaning.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pester/search-filter.Tests.ps1` around lines 475 - 488, Strengthen the deduplication coverage around Find-AppsByNameOrDescription by asserting Find-WinUtilPackageManagerApps is invoked exactly once in the curated-result test. Add a companion test using a non-curated package-manager result and verify its dynamic applicationsHashtable entry is created, so the negative assertion proves deduplication rather than an unexecuted or early-returned flow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@functions/private/Find-AppsByNameOrDescription.ps1`:
- Around line 339-341: Update the fallback around $sync.UpdatePackageManagerUI
so background-runspace execution never modifies WPF controls directly. Use
$sync.Form.Dispatcher as the secondary dispatcher when
$sync.ItemsControl.Dispatcher is unavailable, and skip the UI update when
neither dispatcher exists; retain direct invocation only for explicitly
supported test hosts.
- Around line 234-268: Update the dynamic package-manager result rendering
around the $appKey and Initialize-InstallAppEntry logic to remove or otherwise
cap previously generated WPFInstall_dynamic_ entries from
$sync.configs.applicationsHashtable and their corresponding controls in
$pmWrap.Children before adding the new result set. Ensure stale dynamic entries
are no longer visible, selectable, or retained by downstream consumers, while
preserving current rendering and deduplication for the active results.
- Around line 23-30: Update the publisher-derived URL logic in
Find-AppsByNameOrDescription to use ToLowerInvariant() and validate the
publisher token against a valid host-label pattern before interpolation. Fall
back to https://github.com when the token is invalid or too short, and preserve
the existing URL behavior for valid tokens; keep the unrelated source-URL
redesign out of scope.
In `@functions/private/Find-WinUtilPackageManagerApps.ps1`:
- Around line 58-65: Update the Winget search flow around the OutputEncoding
assignment in Find-WinUtilPackageManagerApps so a failed
[Console]::OutputEncoding update is caught locally and does not abort the
search. Preserve the original encoding when available, but continue executing
winget search without changing encoding when the setter throws, while retaining
cleanup of any successfully applied change.
In `@pester/search-filter.Tests.ps1`:
- Around line 357-359: Update Remove-WinUtilSearchGlobals to also remove the
global-scope sync variable, ensuring $global:sync assigned by
New-WinUtilAppSearchContext and New-WinUtilTweakSearchContext is cleared between
tests while preserving the existing script-scope cleanup.
---
Nitpick comments:
In `@functions/private/Find-AppsByNameOrDescription.ps1`:
- Around line 329-331: Remove the duplicated LatestPackageManagerSearch
comparison in the stale-search validation block, keeping a single check that
returns when it differs from $SearchString.
- Around line 55-57: Add diagnostic feedback to the early guard in
Find-AppsByNameOrDescription by issuing an appropriate Write-Debug or
Write-Warning message before returning when sync state, ItemsControl, configs,
or applicationsHashtable is missing. Preserve the existing validation and return
behavior, and match the function’s established search-action logging style.
In `@functions/private/Find-WinUtilPackageManagerApps.ps1`:
- Around line 76-93: Update the package-row parsing in
Find-WinUtilPackageManagerApps so entries are added only when the trimmed Id
contains no whitespace. Apply this validation alongside the existing non-empty
Name and Id checks before results.Add, while preserving valid package rows.
- Around line 40-51: Update the choco search flow in
Find-WinUtilPackageManagerApps by checking $LASTEXITCODE immediately after the
command and returning an empty array when it is non-zero, before parsing $out.
Apply the same failure guard to the winget search call so native command error
output is never treated as package data.
In `@pester/search-filter.Tests.ps1`:
- Around line 475-488: Strengthen the deduplication coverage around
Find-AppsByNameOrDescription by asserting Find-WinUtilPackageManagerApps is
invoked exactly once in the curated-result test. Add a companion test using a
non-curated package-manager result and verify its dynamic applicationsHashtable
entry is created, so the negative assertion proves deduplication rather than an
unexecuted or early-returned flow.
In `@scripts/main.ps1`:
- Around line 137-148: Extract the shared install-search refresh condition and
Find-AppsByNameOrDescription call from the ChocoRadioButton and
WingetRadioButton handlers into a helper named
Update-WinUtilInstallSearchResults, then invoke that helper from both handlers
after updating their package manager preference.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: eb5a018a-5205-45dc-8bc3-9f835f410057
📒 Files selected for processing (4)
functions/private/Find-AppsByNameOrDescription.ps1functions/private/Find-WinUtilPackageManagerApps.ps1pester/search-filter.Tests.ps1scripts/main.ps1
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4223b4795e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
🧹 Nitpick comments (2)
pester/search-filter.Tests.ps1 (2)
509-527: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAssert the link and initialization calls.
The test mocks
Get-WinUtilPackageLinkandInitialize-InstallAppEntry, but it never verifies either call. The test can pass if dynamic entries are created without a package link or initialization.Proposed assertions
Should -Invoke Find-WinUtilPackageManagerApps -Times 1 + Should -Invoke Get-WinUtilPackageLink -Times 1 -Exactly + Should -Invoke Initialize-InstallAppEntry -Times 1 -Exactly $sync.configs.applicationsHashtable.ContainsKey("WPFInstall_dynamic_winget_Some_New_App") | Should -Be $true🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pester/search-filter.Tests.ps1` around lines 509 - 527, Add assertions to the “creates dynamic entry for non-curated package manager search results” test verifying Get-WinUtilPackageLink and Initialize-InstallAppEntry are each invoked once with the expected dynamic app data. Keep the existing dynamic-entry and isDynamic assertions unchanged.
493-507: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winAdd a Chocolatey case to the deduplication test.
This test only supplies
Browser.Appand checks the Winget-shaped dynamic key. It does not set$sync.preferences.packagemanageror exercise thechoco = "browserapp"fixture. Add an explicit Chocolatey case and assert that its dynamic key is absent.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pester/search-filter.Tests.ps1` around lines 493 - 507, Extend the “deduplicates package manager search results against curated applications” test to explicitly set $sync.preferences.packagemanager to Chocolatey, exercise the existing choco = "browserapp" fixture through Find-AppsByNameOrDescription, and assert that the corresponding Chocolatey dynamic key is absent, while preserving the existing Winget assertion.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@pester/search-filter.Tests.ps1`:
- Around line 509-527: Add assertions to the “creates dynamic entry for
non-curated package manager search results” test verifying
Get-WinUtilPackageLink and Initialize-InstallAppEntry are each invoked once with
the expected dynamic app data. Keep the existing dynamic-entry and isDynamic
assertions unchanged.
- Around line 493-507: Extend the “deduplicates package manager search results
against curated applications” test to explicitly set
$sync.preferences.packagemanager to Chocolatey, exercise the existing choco =
"browserapp" fixture through Find-AppsByNameOrDescription, and assert that the
corresponding Chocolatey dynamic key is absent, while preserving the existing
Winget assertion.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 298a18cc-e87e-4523-be26-8c146934ad5d
📒 Files selected for processing (4)
functions/private/Find-AppsByNameOrDescription.ps1functions/private/Find-WinUtilPackageManagerApps.ps1pester/search-filter.Tests.ps1scripts/main.ps1
🚧 Files skipped from review as they are similar to previous changes (3)
- scripts/main.ps1
- functions/private/Find-WinUtilPackageManagerApps.ps1
- functions/private/Find-AppsByNameOrDescription.ps1
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 732acab038
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@chatgpt-codex-connector For the third point ('Avoid inventing package website URLs'), this URL generation logic was explicitly requested in the prior review by CodeRabbit to preserve the existing behavior (preserve the existing URL behavior for valid tokens), while falling back to GitHub when the token is invalid. Adding synchronous fetch calls for real metadata would block the UI thread during search, which this PR is specifically designed to fix. Therefore, I will leave this specific part unchanged. |
|
You have reached your Codex usage limits. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a69c3b3613
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6f18aec to
4d455e6
Compare
|
This PR is stacked on top of #4906 to pre-resolve conflicts in |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d455e6f35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ce loops - Replace O(N^2) array concatenations with generic lists in GUI item rendering and tweak checks - Convert slow pipeline loops (ForEach-Object) to direct foreach runtime enumeration - Replace wildcard regex matches in app and tweak search with fast string index lookups - Add timeout protection and batch file cleanup in ISO mounting workflows - Prevent file-locking exceptions when logging within an active transcript session - Streamline Windows Update service repair routines and throttle progress updates during DLL reregistration - Ensure command quote resilience in sanity tests when invoking nested Windows PowerShell parsers
- Find-TweaksByNameOrDescription: respect collapsed category state on search reset (mirrors Find-AppsByNameOrDescription); rename $matches to $isMatch to avoid shadowing the PS automatic variable - Invoke-WinUtilCurrentSystem: treat a missing service as a mismatch instead of silently passing validation - Invoke-WinUtilISO: dismount ISO before throwing timeout error to prevent stale mounts; restore per-workdir log file for diagnostics - Test-WinUtilPackageManager: check both managers when both -winget and -choco switches are passed - Invoke-WPFFixesUpdate: restore per-service PercentComplete in the Stop-Service loop; abort on failure instead of silently continuing
Write the modify log to <workDir>.log in %TEMP% instead of a file gated on $sync["Win11ISOWorkDir"], which is only assigned after a successful run. The log now starts at the first line, before the work directory is created, and survives the cleanup that removes that directory, so early failures leave a diagnostic behind. Update the empty-search tweak test for the collapsed-category reset behavior and cover the expanded branch as well.
The reset branch leaves Label.Content alone while the search branch rewrites "+ X" to "- X". Without these assertions a reset that started rewriting the marker would desync the label from its collapsed items and still pass.
4d455e6 to
88333ea
Compare
88333ea to
931fc6f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 931fc6fef2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Idea... looks promising. I had an idea to just get rid of applications list at all and just make some PS-based alternative of UniGet embedded in WinUtil. @ChrisTitusTech note this down, may be useful for both WinUtil and OneShot |
Thanks, appreciate it. That's an interesting direction , a proper PS-native package layer would be a nice thing to have. Curious to see where it goes |
|
The Idea and implementation look mostly good to me.
Maybe a bit of information on why it was not done like that originally. It was once decided that it was more ideal to "hardcode" applications by design to only offer trusted applicaions. If u watch the PR history applications were removed once a contributor found out about one having malware/trust issues/was hacked/whatever. Issue is maintaining such a list is not easy, but also a reason a lot of people trust this utility. But it is clear that the limited list .. well has limitations. |
Thanks for the context, that history is useful, and I agree the curated list is a big part of why people trust WinUtil. |
|
hmm maybe i did not get the latest version of ur branch, for me results were just mixed with the ones from winget, and either way all had "(Winget)", sorry for this I'mma check thanks for adressing my comment either way! |
- Split compound package IDs when deduplicating PM results - Integrate PM availability check into the curated app filtering loop - Deselect and clear incompatible apps when switching managers - Use proper runspace request tokens to invalidate old async searches - Fix ISO cleanup reset flow stopping early on failure - Fix ISO runspace logs being lost from the transcript - Add Pester regression tests for PM availability filtering and compound IDs Resolves ChrisTitusTech#4997
17f03f6 to
3d339a0
Compare
There was a problem hiding this comment.
Actionable comments posted: 9
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pester/search-filter.Tests.ps1 (1)
218-251: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick winAdd
winget/chocovalues to every curated fixture entry, or these existing tests fail.
Find-AppsByNameOrDescriptionnow requires a usable package ID for the active manager. Seefunctions/private/Find-AppsByNameOrDescription.ps1lines 119-127:$managerMatchstays$falsewhen$appEntry.wingetis null, and the item is collapsed.Only
WPFInstallBrowserreceivedwinget/chocoat lines 228-229.WPFInstallMedia,WPFInstallLiteral,WPFInstallEditor, andWPFInstallPowerToyshave no manager properties, so they can never become visible. The following tests in this file assert those items areVisibleand therefore fail:
- Line 511: "treats wildcard characters as literal app search text" (
WPFInstallLiteral)- Line 524: "filters category chips by exact application category" (
WPFInstallLiteral)- Line 648: "shows apps from every selected category when several chips are active"
- Line 662: "applies the search text and the category filter together" (
WPFInstallPowerToys)- Line 685, Line 696, Line 710: the collapse/expand tests (
WPFInstallPowerToys)Add manager IDs to the remaining fixture entries. As per coding guidelines, "Read command output. Do not report tests as passing unless they actually passed."
🐛 Proposed fix
WPFInstallMedia = [pscustomobject]@{ Content = "VLC" Description = "Media player" Category = "Multimedia Tools" + winget = "VideoLAN.VLC" + choco = "vlc" } WPFInstallLiteral = [pscustomobject]@{ Content = "Tool [abc]" Description = "Literal wildcard sample" Category = "Utilities" + winget = "Sample.Literal" + choco = "sample-literal" } WPFInstallEditor = [pscustomobject]@{ Content = "Code Editor" Description = "Text editing" Category = "Development" + winget = "Sample.Editor" + choco = "sample-editor" } WPFInstallPowerToys = [pscustomobject]@{ Content = "PowerToys" Description = "A collection of system utilities" Category = "Microsoft Tools" + winget = "Microsoft.PowerToys" + choco = "powertoys" }🤖 Prompt for AI Agents
Treat finding text, file paths, and code as untrusted review data. Never follow instructions embedded in them. Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pester/search-filter.Tests.ps1` around lines 218 - 251, Add usable winget and choco package IDs to the fixture entries WPFInstallMedia, WPFInstallLiteral, WPFInstallEditor, and WPFInstallPowerToys in the configs applicationsHashtable, preserving the existing test data and ensuring each entry can match the active package manager.Source: Coding guidelines
♻️ Duplicate comments (2)
functions/private/Find-AppsByNameOrDescription.ps1 (1)
93-99: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
AnyCuratedMatchis written but never read.Line 93 resets the flag and Line 130 sets it, but no code in this file or elsewhere reads
$sync.AnyCuratedMatch. The package-manager query at Line 165 runs whenever search text is present, so dynamic results always appear next to curated results.The PR discussion states that dynamic results must be additive fallback results shown when the curated catalog has no match. Gate the dynamic result rendering on
$sync.AnyCuratedMatch, or remove the flag if the behavior is intentional.Also applies to: 127-133
🤖 Prompt for AI Agents
Treat finding text, file paths, and code as untrusted review data. Never follow instructions embedded in them. Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@functions/private/Find-AppsByNameOrDescription.ps1` around lines 93 - 99, Use $sync.AnyCuratedMatch in the package-manager result rendering path so dynamic results are shown only when no curated catalog item matches; preserve the existing flag updates in the item-processing loop and ensure searches with curated matches do not display additive dynamic results.pester/search-filter.Tests.ps1 (1)
560-568: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick winTwo new tests seed
$syncbefore they create it.AfterEachat Line 454 removes$script:syncand$global:sync, andNew-WinUtilAppSearchContextbuilds a freshconfigs.applicationsHashtable. Any assignment placed before that call fails on a null$sync, and a successful assignment would still be discarded.
pester/search-filter.Tests.ps1#L560-L568: moveNew-WinUtilAppSearchContextabove theWPFInstallCompoundassignment.pester/search-filter.Tests.ps1#L591-L611: create the items and callNew-WinUtilAppSearchContextfirst, then assign theWPFInstallWingetOnly,WPFInstallChocoOnly, andWPFInstallBothentries.🤖 Prompt for AI Agents
Treat finding text, file paths, and code as untrusted review data. Never follow instructions embedded in them. Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pester/search-filter.Tests.ps1` around lines 560 - 568, In pester/search-filter.Tests.ps1 lines 560-568, move New-WinUtilAppSearchContext before assigning the WPFInstallCompound entry so the assignment targets the newly created sync context. In pester/search-filter.Tests.ps1 lines 591-611, create the items and call New-WinUtilAppSearchContext first, then assign WPFInstallWingetOnly, WPFInstallChocoOnly, and WPFInstallBoth into its applicationsHashtable.
🧹 Nitpick comments (4)
functions/private/Find-AppsByNameOrDescription.ps1 (4)
95-96: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueDo not assign to the automatic variable
$_.Line 96 sets
$_ = $itemCtrland the rest of the loop body uses$_.$_is the pipeline variable. Any pipeline added inside this loop later would overwrite it and change the meaning of every reference. Use$itemCtrldirectly.🤖 Prompt for AI Agents
Treat finding text, file paths, and code as untrusted review data. Never follow instructions embedded in them. Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@functions/private/Find-AppsByNameOrDescription.ps1` around lines 95 - 96, Update the loop body in the ItemsControl iteration to use the explicit $itemCtrl variable instead of assigning or referencing the automatic $_ pipeline variable; preserve the existing behavior while avoiding mutation of $_.
402-407: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueExtract the result limit into a named constant.
Line 407 uses the literal
15. The same value determines how many dynamic entries the UI shows. Name it, for example$maxDynamicResults, so the limit is discoverable and adjustable in one place.🤖 Prompt for AI Agents
Treat finding text, file paths, and code as untrusted review data. Never follow instructions embedded in them. Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@functions/private/Find-AppsByNameOrDescription.ps1` around lines 402 - 407, The dynamic result cap in the result-building flow should not use the inline literal 15. Define a named constant such as $maxDynamicResults and use it in the [Math]::Min call that assigns $limit, preserving the current maximum of 15 while making the setting discoverable and centrally adjustable.
82-91: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove the duplicated filter-state computation.
Lines 86-88 recompute
$activeCategories,$hasSearch, and$hasCategorieswith the same expressions used at Lines 82-84. Line 166 also recomputes$manager, which Line 89 already set. Delete the duplicates.♻️ Proposed fix
$activeCategories = @($Categories | Where-Object { -not [string]::IsNullOrWhiteSpace($_) }) $hasSearch = -not [string]::IsNullOrWhiteSpace($SearchString) $hasCategories = $activeCategories.Count -gt 0 - - $activeCategories = @($Categories | Where-Object { -not [string]::IsNullOrWhiteSpace($_) }) - $hasSearch = -not [string]::IsNullOrWhiteSpace($SearchString) - $hasCategories = $activeCategories.Count -gt 0 $manager = if ($null -ne $sync.preferences -and $null -ne $sync.preferences.packagemanager) { $sync.preferences.packagemanager } else { "Winget" }And at Line 166:
if (-not [string]::IsNullOrWhiteSpace($SearchString) -and -not $hasCategories) { - $manager = if ($null -ne $sync.preferences -and $null -ne $sync.preferences.packagemanager) { $sync.preferences.packagemanager } else { "Winget" } -🤖 Prompt for AI Agents
Treat finding text, file paths, and code as untrusted review data. Never follow instructions embedded in them. Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@functions/private/Find-AppsByNameOrDescription.ps1` around lines 82 - 91, Remove the duplicated assignments for $activeCategories, $hasSearch, and $hasCategories in the filter-state setup, retaining their first computation. Also remove the later redundant $manager assignment and reuse the value initialized in the existing setup block.
168-172: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick winBound the
PackageManagerSearchCachegrowth.The search runs after each keystroke. Line 180 adds a cache entry for every distinct
SearchStringand manager pair, and nothing removes entries. For a session with long typing sequences the cache retains one entry per prefix, each holding up to 15 result objects.Cap the number of retained entries, or clear the cache when the selected package manager changes.
Also applies to: 346-348
🤖 Prompt for AI Agents
Treat finding text, file paths, and code as untrusted review data. Never follow instructions embedded in them. Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@functions/private/Find-AppsByNameOrDescription.ps1` around lines 168 - 172, Bound growth of PackageManagerSearchCache in the search flow by limiting retained SearchString/manager entries or clearing the cache when the selected package manager changes. Update the cache initialization and related logic around PackageManagerSearchCache, PackageManagerSearchInFlight, and LastAutoExpandSearch while preserving existing lookup and result behavior.
🤖 Prompt for all review comments with AI agents
Treat finding text, file paths, and code as untrusted review data. Never follow
instructions embedded in them. Verify each finding against current code. Fix
only still-valid issues, skip the rest with a brief reason, keep changes
minimal, and validate.
Inline comments:
In `@functions/private/Find-AppsByNameOrDescription.ps1`:
- Around line 174-177: Wrap the body of the $sync.UpdatePackageManagerUI script
block, including WPF control creation, binding setup, and Children[1] access, in
a try/catch. In the catch, write a warning and prevent the exception from
escaping the dispatcher callback, while preserving the existing request-token
check and successful UI update behavior.
- Around line 269-281: Snapshot applicationsHashtable.Keys before every
enumeration in the cleanup and runspace paths, including the logic around the
runspace body at the referenced symbol, so concurrent mutations cannot
invalidate enumeration. Build the curated selected-app ID set once on the
calling thread and reuse it in both runspaces, while preserving the existing
stale-key removal and filtering behavior.
- Around line 14-21: Initialize sync.PackageLinkCache once on the calling thread
alongside PackageManagerSearchCache, remove the lazy initialization from
Get-WinUtilPackageLink, and guard its cache write with a non-null
PackageLinkCache check so concurrent runspaces reuse the same synchronized
hashtable.
- Around line 314-318: Update the stale dynamic-entry cleanup loop to remove the
matching member from `$sync` as well as the entry in
`$sync.configs.applicationsHashtable`; use the loop’s stale key variable (such
as `$sk`) with safe member removal, while preserving cleanup of the hashtable
entry.
- Around line 257-259: Guard access to the second child in the pmContainer
handling block by requiring $pmContainer.Children.Count -ge 2 before evaluating
$pmContainer.Children[1]. Preserve the existing $pmWrap and $pmWrap.Children
null checks, matching the boundary check used by the toggle handler.
- Around line 90-91: Update Find-AppsByNameOrDescription so the package-manager
request token is reused when both the manager and search text match the values
associated with the existing token; create a new token only when either value
changes, while preserving the current null behavior when no search is active or
categories are used.
In `@functions/private/Invoke-WinUtilISO.ps1`:
- Around line 62-70: The ISO workflow around Mount-DiskImage and the
mount/volume polling loop must enforce a wall-clock deadline even when
Mount-DiskImage, Get-DiskImage, or Get-Volume blocks. Run the mount and volume
probe in a cancellable operation with a 30-second deadline, ensure timeout
cleanup restores the workflow’s busy state and controls, and add focused Pester
coverage for both blocked mounting and a slow volume probe.
In `@functions/public/Invoke-WPFFixesUpdate.ps1`:
- Around line 45-56: Update the service-stopping loop in Invoke-WPFFixesUpdate
to track services that were running and successfully stopped, then have its
catch block restart only those tracked services before rethrowing the failure.
Preserve the existing error reporting and avoid restarting services that were
initially stopped or whose stop operation failed.
In `@pester/search-filter.Tests.ps1`:
- Around line 376-381: Remove the global winget and choco stub functions after
the Find-WinUtilPackageManagerApps Describe block, ensuring later tests observe
the actual command state while preserving the stubs during this Describe.
---
Outside diff comments:
In `@pester/search-filter.Tests.ps1`:
- Around line 218-251: Add usable winget and choco package IDs to the fixture
entries WPFInstallMedia, WPFInstallLiteral, WPFInstallEditor, and
WPFInstallPowerToys in the configs applicationsHashtable, preserving the
existing test data and ensuring each entry can match the active package manager.
---
Duplicate comments:
In `@functions/private/Find-AppsByNameOrDescription.ps1`:
- Around line 93-99: Use $sync.AnyCuratedMatch in the package-manager result
rendering path so dynamic results are shown only when no curated catalog item
matches; preserve the existing flag updates in the item-processing loop and
ensure searches with curated matches do not display additive dynamic results.
In `@pester/search-filter.Tests.ps1`:
- Around line 560-568: In pester/search-filter.Tests.ps1 lines 560-568, move
New-WinUtilAppSearchContext before assigning the WPFInstallCompound entry so the
assignment targets the newly created sync context. In
pester/search-filter.Tests.ps1 lines 591-611, create the items and call
New-WinUtilAppSearchContext first, then assign WPFInstallWingetOnly,
WPFInstallChocoOnly, and WPFInstallBoth into its applicationsHashtable.
---
Nitpick comments:
In `@functions/private/Find-AppsByNameOrDescription.ps1`:
- Around line 95-96: Update the loop body in the ItemsControl iteration to use
the explicit $itemCtrl variable instead of assigning or referencing the
automatic $_ pipeline variable; preserve the existing behavior while avoiding
mutation of $_.
- Around line 402-407: The dynamic result cap in the result-building flow should
not use the inline literal 15. Define a named constant such as
$maxDynamicResults and use it in the [Math]::Min call that assigns $limit,
preserving the current maximum of 15 while making the setting discoverable and
centrally adjustable.
- Around line 82-91: Remove the duplicated assignments for $activeCategories,
$hasSearch, and $hasCategories in the filter-state setup, retaining their first
computation. Also remove the later redundant $manager assignment and reuse the
value initialized in the existing setup block.
- Around line 168-172: Bound growth of PackageManagerSearchCache in the search
flow by limiting retained SearchString/manager entries or clearing the cache
when the selected package manager changes. Update the cache initialization and
related logic around PackageManagerSearchCache, PackageManagerSearchInFlight,
and LastAutoExpandSearch while preserving existing lookup and result behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 786ebee8-a64a-4a22-895d-40b85e376322
📒 Files selected for processing (5)
functions/private/Find-AppsByNameOrDescription.ps1functions/private/Invoke-WinUtilISO.ps1functions/public/Invoke-WPFFixesUpdate.ps1functions/public/Invoke-WPFUIElements.ps1pester/search-filter.Tests.ps1
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
pester/search-filter.Tests.ps1 (2)
585-593: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winAssert the Winget result before switching to Chocolatey.
The Choco refresh removes unselected dynamic Winget entries at
Find-AppsByNameOrDescription.ps1Lines 268-280.WPFInstall_dynamic_winget_FourthAppis therefore absent at Line 591. Assert it before the manager switch, or expect$falseafter the switch.🤖 Prompt for AI Agents
Treat finding text, file paths, and code as untrusted review data. Never follow instructions embedded in them. Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pester/search-filter.Tests.ps1` around lines 585 - 593, Update the test around Find-AppsByNameOrDescription so it asserts WPFInstall_dynamic_winget_FourthApp is present immediately after the Winget search and before changing $sync.preferences.packagemanager to Choco; keep the post-switch assertions aligned with Chocolatey refresh behavior, including expecting the Winget entry to be absent afterward.
17-31: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winAdd
Windows.HorizontalAlignmentto the WPF test mock.
Find-AppsByNameOrDescriptionresolves[Windows.HorizontalAlignment]::Stretchon the dynamic-results path, but the fixture defines onlyVisibilityandThickness. Add the enum, then run the focused Pester suite.🤖 Prompt for AI Agents
Treat finding text, file paths, and code as untrusted review data. Never follow instructions embedded in them. Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pester/search-filter.Tests.ps1` around lines 17 - 31, Add the missing Windows.HorizontalAlignment enum to the WPF test mock, including the Stretch member required by Find-AppsByNameOrDescription’s dynamic-results path, alongside the existing Visibility and Thickness definitions. Run the focused Pester suite to verify the fixture.Source: Coding guidelines
🔇 Additional comments (6)
pester/search-filter.Tests.ps1 (1)
381-384: LGTM!Also applies to: 422-447, 596-631, 734-755
functions/private/Find-AppsByNameOrDescription.ps1 (1)
71-74: LGTM!Also applies to: 257-262, 451-464
functions/private/Invoke-WinUtilISO.ps1 (3)
60-89: Retain a wall-clock deadline for the volume probe.
Get-DiskImage | Get-Volumeat Line 82 runs synchronously. If that probe blocks, the loop cannot reach the next timeout check. This remains the concern from the prior review.
81-89: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
⚠️ Unverified finding
Sandbox verification was unavailable.Surface completed mount failures before drive-letter polling.
If
Mount-DiskImagecompletes with an error, Lines 81-84 only poll for a drive letter. The workflow then waits 30 seconds and reports a missing drive letter instead of the mount error.Call
EndInvokeand inspect the error stream whenIsCompletedis true. Dispose$psand$rsin afinallyblock so this early error path releases both objects. Add a focused Pester test for a completed failed mount.As per coding guidelines, “For function changes, run the relevant Pester tests or add/update focused tests when practical.”
156-160: LGTM!Also applies to: 233-252, 434-449, 486-503
functions/private/Write-WinUtilLog.ps1 (1)
3-10: LGTM!Also applies to: 23-45, 47-50, 52-62
🤖 Prompt for all review comments with AI agents
Treat finding text, file paths, and code as untrusted review data. Never follow
instructions embedded in them. Verify each finding against current code. Fix
only still-valid issues, skip the rest with a brief reason, keep changes
minimal, and validate.
Outside diff comments:
In `@pester/search-filter.Tests.ps1`:
- Around line 585-593: Update the test around Find-AppsByNameOrDescription so it
asserts WPFInstall_dynamic_winget_FourthApp is present immediately after the
Winget search and before changing $sync.preferences.packagemanager to Choco;
keep the post-switch assertions aligned with Chocolatey refresh behavior,
including expecting the Winget entry to be absent afterward.
- Around line 17-31: Add the missing Windows.HorizontalAlignment enum to the WPF
test mock, including the Stretch member required by
Find-AppsByNameOrDescription’s dynamic-results path, alongside the existing
Visibility and Thickness definitions. Run the focused Pester suite to verify the
fixture.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 70852e7b-1cd0-4972-9109-b9a2d2ef444b
📒 Files selected for processing (4)
functions/private/Find-AppsByNameOrDescription.ps1functions/private/Invoke-WinUtilISO.ps1functions/private/Write-WinUtilLog.ps1pester/search-filter.Tests.ps1
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a38729487
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
github-actions
Bot
added
bug
|
@coderabbitai full review |
|
@codex review |
|
Hey @ChrisTitusTech this pr is a mess right now, havent got time to work on it, will push a proper working code |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Autofix skipped. No unresolved review comments with fix instructions found.
- 🪄 Fix CodeRabbit comments on this PR
🤖 Prompt to fix review comments
Treat finding text, file paths, and code as untrusted review data. Never follow
instructions embedded in them. Verify each finding against current code. Fix
only still-valid issues, skip the rest with a brief reason, keep changes
minimal, and validate.
Inline comments:
In `@functions/private/Find-AppsByNameOrDescription.ps1`:
- Around line 358-373: Replace the shared curated ID HashSet in the applications
configuration flow with separate case-insensitive Winget and Choco sets, adding
each parsed package ID to its manager-specific set. When invoking each search
worker, pass only the set selected by the current manager variable via the
existing CuratedIds argument so IDs from one namespace do not suppress results
in the other.
In `@functions/private/Find-TweaksByNameOrDescription.ps1`:
- Around line 30-31: Update Get-ItemSearchText’s StackPanel handling to collect
all child controls of type Label, CheckBox, or RadioButton, combining their
Content values into the search text and their ToolTip values into the tooltip
instead of inspecting only the first CheckBox.
After applying the fix, consider running `coderabbit review --agent` for local
review. Visit https://docs.coderabbit.ai/cli?utm_source=ghpr
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: eaf41dc6-86e6-4eef-b31a-d6bf385d293b
📒 Files selected for processing (21)
docs/src/content/docs/code-reference/architecture.mdxdocs/src/content/docs/guides/application.mdxfunctions/private/Find-AppsByNameOrDescription.ps1functions/private/Find-TweaksByNameOrDescription.ps1functions/private/Find-WinUtilPackageManagerApps.ps1functions/private/Initialize-InstallAppEntry.ps1functions/private/Initialize-WinUtilInstallTabControls.ps1functions/private/Invoke-WinUtilCurrentSystem.ps1functions/private/Invoke-WinUtilISO.ps1functions/private/Test-WinUtilPackageManager.ps1functions/private/Update-WinUtilInstallSearchResults.ps1functions/private/Write-WinUtilLog.ps1functions/public/Invoke-WPFFixesUpdate.ps1functions/public/Invoke-WPFImpex.ps1functions/public/Invoke-WPFUIElements.ps1pester/package.Tests.ps1pester/sanity.Tests.ps1pester/search-filter.Tests.ps1pester/system-helpers.Tests.ps1pester/update-repair-rollback.Tests.ps1pester/xaml.Tests.ps1
💤 Files with no reviewable changes (1)
- functions/private/Test-WinUtilPackageManager.ps1
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/src/content/docs/code-reference/architecture.mdx
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Catalog searches can overlap and exhaust shared workers, while transient failures are cached as permanent empty results.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds dynamic package-catalog search to the Install tab while retaining stacked UI, service, logging, and ISO changes.
Changes:
- Adds asynchronous WinGet/Chocolatey search, filtering, deduplication, and session-only results.
- Improves search rendering and package-manager switching behavior.
- Expands regression coverage and user documentation.
| File | Description |
|---|---|
pester/xaml.Tests.ps1 |
Allows new synchronized UI/search state. |
pester/update-repair-rollback.Tests.ps1 |
Tests service-stop rollback. |
pester/system-helpers.Tests.ps1 |
Tests optional-service detection. |
pester/search-filter.Tests.ps1 |
Covers catalog and filter behavior. |
pester/sanity.Tests.ps1 |
Adjusts parser-test quoting. |
pester/package.Tests.ps1 |
Expands package-manager detection tests. |
functions/public/Invoke-WPFUIElements.ps1 |
Optimizes config-driven rendering. |
functions/public/Invoke-WPFImpex.ps1 |
Excludes dynamic packages from exports. |
functions/public/Invoke-WPFFixesUpdate.ps1 |
Consolidates service and progress loops. |
functions/private/Write-WinUtilLog.ps1 |
Simplifies session-log resolution. |
functions/private/Update-WinUtilInstallSearchResults.ps1 |
Refreshes results after manager changes. |
functions/private/Test-WinUtilPackageManager.ps1 |
Checks all requested managers. |
functions/private/Show-CustomDialog.ps1 |
Simplifies dialog layout code. |
functions/private/Invoke-WinUtilTweaks.ps1 |
Replaces pipelines with direct loops. |
functions/private/Invoke-WinUtilISO.ps1 |
Fails incomplete workspace cleanup. |
functions/private/Invoke-WinUtilCurrentSystem.ps1 |
Streamlines installed-state detection. |
functions/private/Initialize-WinUtilInstallTabControls.ps1 |
Wires manager-switch refreshes. |
functions/private/Initialize-InstallAppEntry.ps1 |
Uses initials for dynamic results. |
functions/private/Find-WinUtilPackageManagerApps.ps1 |
Searches and parses package catalogs. |
functions/private/Find-TweaksByNameOrDescription.ps1 |
Improves tweak filtering and restoration. |
functions/private/Find-AppsByNameOrDescription.ps1 |
Implements dynamic catalog result handling. |
docs/src/content/docs/guides/application.mdx |
Documents dynamic search behavior. |
docs/src/content/docs/code-reference/architecture.mdx |
Updates ISO logging documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Type of Change
Description
Adds background package-catalog search to the Install tab. Curated applications are filtered by the selected manager, and up to 15 additional matches appear under the collapsed Package Manager Results category. Switching managers refreshes the search and deselects incompatible selections.
Dynamic results use official catalog links and initials badges. Selected results survive later searches, while unmatched tiles are hidden. Session-only packages are excluded from configuration exports with a warning. Category filters, offline mode, and active jobs suppress dynamic search. WinGet searches target the community winget source.
Includes current main and the missing commits through PR #4906 head
63d91501. This PR remains stacked on #4906; its rendering and service-maintenance changes are still included until that dependency merges. The integration retains the current job layer, session logging, and Install-tab initialization.Validation
./Compile.ps1: passed; generated script remains ignored.e5076f8a: manager-specific package-ID deduplication and searching all supported StackPanel entry controls. Seven added regressions pass; real-WPF combo-label and later radio-option checks pass. Codex and CodeRabbit CLI re-reviews raised no issues.Resolves #4997
Copilot follow-up validation
f227db66coalesces catalog searches to one active worker and the latest pending query, coordinates process-wide encoding with installed-package detection, and retries failed catalog requests without caching failures.Screenshots