-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NVDA 2024.1: switch to requiring 2024.1 or later #163
Comments
Hi, Actually, typing.Any -> NVDAObject conversion will be deferred until Python 3.11 pull request is merged. Thanks. |
I'd propose until the next stable rlease of 2024, but wasn't sure what your thoughts were on that? The reason for this is some may have add-ons that are not yet compatible with 2024 even a few weeks or months after the first stable. I'd hope this year's transition will be a better one than previous years, but wanted to keep that in mind. Of course, right now it's set to 2022.4 as the minimum required version, but I can change it to 2023.1 since that's the earliest I've technically tested (really 2023.3). I can address this in the Readme once I release the Stable build. |
Hi, I agree – 2024.2 release timeframe seems reasonable. At the moment NVDA’s release process specifies at least eight weeks between releases (based on current release process document), so the earliest we can ask folks to upgrade to 2024.1 or later would be middle of northern spring (say, April or so). Thanks.
|
Hi, For minimum NVDA version, I think we can change it once we do move to requiring NVDA 2024.1 or later. Thanks. |
Hi, Update: let's do this as part of a massive code rewrite - I'm thinking about reviving this add-on repo to add support for SPL 6.11 and to do a Ruff format conversion. After that, let's do NVDA 2024.1 requirement. Thanks. |
Hi,
The following builds on #161:
Now that main branch supports NVDA 2024.1 changes, I propose moving to requring NVDA 2024.1 in a future ad-on release. This wil mean strictly using Python 3.11 syntax, speech on demand syntax in 2024.1, among others.
To give time for folks to migrate to the future release, I propose the following process:
I will create two pull requests:
I will submit these pull requests shortly after 2024.1 compatibility version is released (after step 1). In preparation for these, I will deal with some type hinting issues such as proper typing information for NVDA object, mostly to replace typing.Any usage with proper NVDA object type hint to make the code more readable.
Thanks.
The text was updated successfully, but these errors were encountered: