[Bug]: Number of images to download is not respected

[mdtanveer]

Severity

S2 - High (major feature broken)

Version / Commit

0.3.7 (latest)

What happened?

image_client = imagedl.ImageClient(image_source='GoogleImageClient', search_limits=20, num_threadings=5) image_infos = image_client.search("black cat", search_limits_overrides=10) image_client.download(image_infos=image_infos)
Tried the above snippet. Neither search_limits=20 nor search_limits_overrides=10 is respected. It downloads almost ~200 images

What did you expect?

I expect to download only 10 images and stop.

Steps to reproduce

image_client = imagedl.ImageClient(image_source='GoogleImageClient', search_limits=20, num_threadings=5) image_infos = image_client.search("black cat", search_limits_overrides=10) image_client.download(image_infos=image_infos)

Logs / Screenshots

Environment

No response

Checklist

• I searched existing issues and did not find a duplicate.
• I can reproduce this consistently.