Regression: bluedog_Titan_S2_Tank has 0 volume

[SerShrubert]

bluedog_Titan_S2_Tank.txt

Change added in 9388f06#diff-67fcf319801be0c932ad4b7495b095c52d06707814ecef052497aca7aba5630eR17
causes volume on bluedog_Titan_S2_Tank to be 0. The first patch is setting the ModuleB9PartSwitch module with the moduleID realnameMeshSwitchTank to have a volume of 0, but since this module does not have a tanktype it does not get fixed later.

This part has 3 subtypes but only one of them modifies fuel volume. The Titan4 subtype has volumeAddedToParent:NEEDS[!RealFuels] = 240, but the other 2 don't have any fuel volume.

I have also attached the patch history for this part.
7288_bluedog_Titan_S2_Tank_MMPatchesHistory.txt

[SerShrubert]

Reverting the change to the first 2 patches in chemical-propulsion-ignition-tank-convert-switch.cfg does fix the issue. Not sure what this change was supposed to fix or what may be. I can run a diff on the MM output to see what else is affected.

In the 3rd patch:
@part:HAS[@module[ModuleB9PartSwitch]:HAS[#chemTechConvertTankSwitch[true]]]:FOR[zzz_ChemicalPropulsion]
{
// Tank switches changing type, must have a baseVolume so use that
@module[ModuleB9PartSwitch]:HAS[#chemTechConvertTankSwitch[true],@subtype:HAS[#tankType]]
{
@subtype:HAS[~tankType],*
{......
Will @subtype:HAS[~tankType],* ever execute? Its parent patch will only run if the SUBTYPE has a tankType value, and this one will only run if the SUBTYPE doesn't.

[SerShrubert]

There are some negative tank volumes as well.

The reverted patch volumes seem correct. I didn't see anything obviously wrong in the diff. Fixed version:

chemical-propulsion-Ignition-tank-convert-switch.cfg.txt

[CharleRoger]

The purpose of the change you've highlighted was to try to handle different types of B9PartSwitches which change the tank volume in different ways and convert them all to apply those volume changes to the ModuleIgnitionTankController. I think I just made a small mistake in the logic. Your suggested fix seems to be correct, I haven't found any issues on other parts I would expect to be affected by it.

[CharleRoger]

Fixed in 1.6.2.