Compatibility with Universal Storage II

[Shnpl]

Observed affected part:
Eight Bay Service Core from Universal Storage II

How to reproduce:

1. Start game with the listed mods.
2. In VAB, place "Eight Bay Service Core (2.5m)" from Universal Storage II.
3. Select a Chemical Tech resource variant (e.g. Kerosene/Ox or Hydrazine/NTO).
4. Launch the vessel.
5. Observe that the part disappears in flight (no mesh and no collider).

Expected result:
The part remains visible and functional after launch.

Actual result
The mesh and collider disappear in flight scene, but the resource panel still shows the resources. The KJR and FAR mods are also broken by this bug.

Fig.1 Stock resource Xenon works correctly on US II

Fig.2 Passable variant containing no resource works correctly on US II

Fig.3 Kerosene/Ox variant added by Chemical Tech causes the "Eight Bay Service Core" to disappear! Although the resources are still visible on the Resources panel.

Relevant Mods & Versions:

• Universal Storage II Finalized (UniversalStorage2 4.0.3)
• Ferram Aerospace Research Continued (FerramAerospaceResearchContinued 3:0.16.1.2)
• Chemical Core (ChemicalCore 1.4.4)
• Chemical Propulsion (ChemicalPropulsion 1.5.6.1)
• B9 Part Switch (B9PartSwitch v2.21.0.4)
• KSP 1.12.5.3190 (WindowsPlayer x64) en-us

Relevant Logs:
...
[WRN 05:22:30.725] [KJR] extents could not be properly built for part Universal Storage: Eight Bay Service Core (2.5m)
[WRN 05:22:30.726] [KJR] extents could not be properly built for part Universal Storage: Eight Bay Service Core (2.5m)
[WRN 05:22:30.726] [KJR] extents could not be properly built for part Universal Storage: Eight Bay Service Core (2.5m)
[WRN 05:22:30.729] [KJR] extents could not be properly built for part Universal Storage: Eight Bay Service Core (2.5m)
[WRN 05:22:30.731] [KJR] extents could not be properly built for part Universal Storage: Eight Bay Service Core (2.5m)
[WRN 05:22:30.734] [KJR] extents could not be properly built for part Universal Storage: Eight Bay Service Core (2.5m)
[LOG 05:22:30.848] KK: [LaunchSiteManager] GetCurrentLaunchSite: retuning CurrentSite: LaunchPad
[LOG 05:22:30.848] KK: [LaunchSiteManager] GetLaunchSiteByName: found LS: LaunchPad
[LOG 05:22:30.943] [UIMasterController]: ShowUI
[LOG 05:22:30.980] [FAR v0.16.1.2]: Overall bounds error in Universal Storage: Eight Bay Service Core (2.5m) 0 meshes
[LOG 05:22:30.990] [FAR v0.16.1.2]: Updating vessel voxel for Liner-04 LKO
[LOG 05:22:31.025] [FAR v0.16.1.2]: Overall bounds error in Universal Storage: Eight Bay Service Core (2.5m) 0 meshes
[LOG 05:22:31.175] [FAR v0.16.1.2]: Voxel Element CrossSection Area: NaN
[ERR 05:22:31.175] [FAR v0.16.1.2]: FAR VOXEL ERROR: Voxel CrossSection Area is NaN at section 0

[ERR 05:22:31.175] [FAR v0.16.1.2]: FAR VOXEL ERROR: Voxel CrossSection Area is NaN at section 1

[ERR 05:22:31.176] [FAR v0.16.1.2]: FAR VOXEL ERROR: Voxel CrossSection Area is NaN at section 2
...
Full Mods List:
AlphaMensae's Modular Launch Pads (ModularLaunchPads 2.9.0)
ASET Consolidated Agency (ASETAgency v2.0.2)
ASET Consolidated Avionics Pack (ASETAvionics v3.0.1)
ASET Consolidated Props Pack (ASETProps v2.0.7)
Astrogator (Astrogator v1.0.2)
Avionics Systems (AvionicsSystems v1.3.7)
B9 Aerospace Procedural Wings - Fork (B9-PWings-Fork 3:0.46.1)
B9 Part Switch (B9PartSwitch v2.21.0.4)
Breaking Ground (BreakingGround-DLC 1.7.1)
Chatterer (Chatterer 0.9.99)
Chemical Core (ChemicalCore 1.4.4)
Chemical Propulsion (ChemicalPropulsion 1.5.6.1)
Chemical Propulsion - Nuclear (ChemicalPropulsionNuclear 1.5.6.1)
ClickThrough Blocker (ClickThroughBlocker 1:2.1.10.22)
Community Category Kit (CommunityCategoryKit v112.0.1)
Community Resource Pack (CommunityResourcePack v112.0.1)
Community Tech Tree (CommunityTechTree 1:3.4.5)
Contract Configurator (ContractConfigurator v2.12.2.0)
Contract Pack: Bases and Stations Reborn (ContractConfigurator-KerbinSpaceStation 2:3.7.3.3)
CorrectCoL (CorrectCoL 1.6.5.5)
Craft Manager (CraftManager 1.2.0)
Crew R&R (CrewQueueTwo 1.1.11.5)
Cryo Tanks (CryoTanks 1.6.7)
Cryo Tanks Core (CryoTanks-Core 1.6.7)
Cryogenic Engines (CryoEngines 1:2.0.8)
Custom Barn Kit (CustomBarnKit 1.1.22.0)
Custom Pre Launch Checks (CustomPreLaunchChecks 1.8.1.1)
DE_IVAExtension (DE-IVAExtension v1.2.0)
Deployable Engines Plugin (DeployableEngines 1.3.1)
Distant Object Enhancement /L (DistantObject v2.2.1.5)
Distant Object Enhancement /L default config (DistantObject-default v2.2.1.5)
Docking Port Alignment Indicator (DockingPortAlignmentIndicator 6.12.0.0)
Dynamic Battery Storage (DynamicBatteryStorage 2:2.3.7.0)
Environmental Visual Enhancements Redux (EnvironmentalVisualEnhancements 3:1.11.7.2)
Ferram Aerospace Research Continued (FerramAerospaceResearchContinued 3:0.16.1.2)
Firefly (Firefly 1.0.5)
FireflyAPI (FireflyAPI 1.0.0.0)
FreeIva (FreeIva 0.2.20.2)
Hangar Extender (HangerExtenderExtended 3.6.1)
Harmony 2 (Harmony2 2.2.1.0)
Heat Control (HeatControl 0.6.2)
Hide Empty Tech Tree Nodes (HideEmptyTechNodes 1.3.2)
HUD Replacer (HUDReplacer 1.3.3)
Ignition! (Ignition 1.2.2.1)
Improved and Updated Chase Camera (ImprovedUpdatedChaseCam 1.6.4.4)
JNSQ (JNSQ 0.10.2)
Kerbal Changelog (KerbalChangelog v1.4.2)
Kerbal Joint Reinforcement Continued (KerbalJointReinforcementContinued v3.8.6.0)
Kerbal Konstructs (KerbalKonstructs v1.12.0.0)
Kerbal Planetary Base Systems (KerbalPlanetaryBaseSystems v1.6.16)
Kerbal Reusability Expansion (SpaceXLegs 2.9.3)
Kerbalism (Kerbalism 3.31)
Kerbalism - Default Config (Kerbalism-Config-Default 3.31)
Kerbalism Compatibility Overhaul (KerbalismCompatibilityOverhaul 1.0.0)
Kerbalism System Heat (Kerbalism-SystemHeat 0.5.0)
Kerbals Get Old! (KerbalsGetOld 1.1)
Kopernicus Planetary System Modifier (Kopernicus 2:release-1.12.1-238)
Kronometer (Kronometer v1.12.0.2)
KSC Extended (KSCExtended 3.0.3)
KSP Community Fixes (KSPCommunityFixes v1.40.1)
KSP Rescue Contract Fix (KSPRescueContractFix 1.1.0)
KSP Texture Loader (KSPTextureLoader 0.0.22)
KSPBurst Compiler (KSPBurst v1.5.5.2)
KSPBurst Plugins (KSPBurst-Lite v1.5.5.2)
KXAPI (KXAPI 1.2.0)
LoadingTipsPlus (LoadingTipsPlus V1.9)
Making History (MakingHistory-DLC 1.12.1)
MechJeb 2 (MechJeb2 2.14.3.0)
MechJeb Embedded Universal (Career mode) (MechJebEmbeddedUniversalCareer 1.3)
Mk3 Stockalike Expansion (Mk3Expansion 1.6.1.4)
MOAR Station Science (MOARStationScience v2.6.2.1)
ModularFlightIntegrator (ModularFlightIntegrator 1.2.10.0)
Module Manager (ModuleManager 4.2.3)
Near Future Construction (NearFutureConstruction 1.3.3)
Near Future Electrical (NearFutureElectrical 2.0.1)
Near Future Electrical Core (NearFutureElectrical-Core 2.0.1)
Near Future Exploration (NearFutureExploration 1.1.3)
Near Future IVA Props (NearFutureProps 1:0.7.2)
Near Future Launch Vehicles (NearFutureLaunchVehicles 2.2.2)
Near Future Propulsion (NearFuturePropulsion 1.3.6)
Near Future Solar (NearFutureSolar 1.3.3)
Near Future Solar Core (NearFutureSolar-Core 1.3.3)
Near Future Spacecraft (NearFutureSpacecraft 1.4.6)
OCCULT (OCCULT 1.4.3.0)
Omega's Stockalike Structures: No Textures Required (StockalikeStructures 0.0.12)
Patch Manager (PatchManager 0.0.17.7)
Plane Mode (PlaneMode 1.4.5)
PlanetShine (PlanetShine 0.2.6.6)
PlanetShine - Default configuration (PlanetShine-Config-Default 0.2.6.6)
Probes Before Crew [PBC] (ProbesBeforeCrew 3.0.0)
Procedural Fairings (ProceduralFairings 1:v6.7.0.0)
Procedural Parts (ProceduralParts v2.8.0.0)
Procedural Parts - MainSailor's Procedural Textures - Complete Texture Pack (MainSailorTextures-Complete 2.0.0.0.1)
Procedural Parts - MainSailor's Procedural Textures - Essential Textures and Flag (MainSailorTextures-Essentials 2.0.0.0.1)
RasterPropMonitor (RasterPropMonitor 1:v1.0.2)
RasterPropMonitor Core (RasterPropMonitor-Core 1:v1.0.2)
Rational Resources (RationalResources 3.4.2)
RCS Build Aid (RCSBuildAid v1.0.6)
RealChute for Stock (RealChuteForStock v1.4.9.5)
RealChute Parachute Systems (RealChute v1.4.9.5)
ReStock (ReStock 1.5.1)
ReStock+ (ReStockPlus 1.5.1)
Reviva (Reviva 1.0.2)
ROUtils (ROUtils v1.1.1.0)
SCANsat (SCANsat v21.1)
Scatterer (Scatterer 3:v0.0878)
Scatterer Default Config (Scatterer-config 3:v0.0878)
Scatterer Sunflare (Scatterer-sunflare 3:v0.0878)
SpaceTux Library (SpaceTuxLibrary 0.0.9)
Staged Animation (StagedAnimation v2.0)
StageRecovery (StageRecovery 1.9.8)
Station Keeping (StationKeeping 1:0.2.3.2)
Stockalike Station Parts Expansion Redux (StationPartsExpansionRedux 2.0.11)
Stockalike Station Parts Expansion Redux - Internal Spaces (StationPartsExpansionRedux-IVAs 2.0.11)
Strategia (Strategia 1.8.0)
System Heat (SystemHeat 0.8.2)
System Heat - Nuclear Engine Configuration (SystemHeat-FissionEngines 0.8.2)
System Heat - Nuclear Reactor Configuration (SystemHeat-FissionReactors 0.8.2)
Toolbar Controller (ToolbarController 1:0.1.9.14)
Tourism Overhaul (TourismOverhaul 1.2.2)
Tundra's Space Center (TundraSpaceCenter 2.0.2)
TweakScale Rescaled (TweakScaleRescaled 3.3.1)
TweakScale Rescaled Redistributable (TweakScaleRescaled-Redist 3.3.1)
TweakScale Rescaled SafetyNet (TweakScaleRescaled-SafetyNet 3.3.1)
Universal Storage II Finalized (UniversalStorage2 4.0.3)
VAB Organizer (VABOrganizer 1.1.0)
VABReorienter (VABReorienter 1.2)
Vessel Viewer Continued (VesselView 2:0.8.9)
VesselView-UI-RasterPropMonitor (VesselView-UI-RasterPropMonitor 1:0.8.9)
VexarpIVA (VexarpIVA 0.6.1)
Waterfall - Restock (WaterfallRestock 0.2.3)
Waterfall Core (Waterfall 0.10.5)
WaypointManager (WaypointManager 2.8.4.7)
ZTheme (ZTheme v1.2.1)

[jvosk]

Not sure if related to this issue; there appears to be an extra # hash in a VariantColors assignment that affects this part:

ChemicalPropulsion/GameData/ChemicalPropulsion/Patches/Compatibility/chemical-propulsion-UniversalStorage2.cfg

Lines 450 to 457 in ed8a281

	@PART[USPenticore,USHexcore,USOctocore]:NEEDS[UniversalStorage2]:FOR[zzz_ChemicalPropulsion]
	{
	@MODULE[USSwitchControl]:HAS[#chemTechUSSwitchControl[true]]
	{
	%ObjectNames = #autoLOC_US_CrewTransferTunnel;
	%VariantColors = ##c5c5c5,#c5c5c5;
	}
	}

I imagine that could be causing something to choke on the part?

Separately, for @PART[USOctocore], the chemTechUSCost{\d} value assignment progression had me wondering if the largest tank volume size is missing the addition of Xenon cost:

// Set part-specific baseline parameters and mesh transforms and add chemTech tags to patched modules
@PART[USOctocore]:NEEDS[UniversalStorage2]:BEFORE[zzz_ChemicalPropulsion]
{
	@MODULE[USFuelSwitch]:HAS[#SwitchID[0;1]]
	{
		chemTechUSFuelSwitch = true
		chemTechUSVolume1 = 320
		chemTechUSCost1 = 31
		// ...
		chemTechUSCost2 = 531
	}

// Compute tank volumes, masses and costs
@PART[USAerozineWedge,USHydrazineWedge,USPenticore,USHexcore,USOctocore,USAdaptorShroud1250Soyuz,USCylindricalShroud1500,USCylindricalShroud1500ResizedTo1875-2]:NEEDS[UniversalStorage2]:FOR[zzz_ChemicalPropulsion]
{
	@MODULE[USFuelSwitch]:HAS[#chemTechUSFuelSwitch[true]]
	{

		chemTechUSCost3 = #$chemTechUSCost2$	// = 531
		@chemTechUSCost3 -= #$chemTechUSCost1$	// = 500
		@chemTechUSCost3 *= 2					// = 1000
		@chemTechUSCost3 += #$chemTechUSCost1$	// = 1031

		chemTechUSCost4 = #$chemTechUSCost2$	// = 531
		@chemTechUSCost4 -= #$chemTechUSCost1$	// = 500
		@chemTechUSCost4 *= 3					// = 1500
		@chemTechUSCost4 += #$chemTechUSCost1$	// = 1531

		%tankCost = #$chemTechUSCost1$;$chemTechUSCost2$;$chemTechUSCost3$;$chemTechUSCost4$
		// %tankCost = 31;531;1031;1531
	}
}

// Add Xenon to structural cores
@PART[USPenticore,USHexcore,USOctocore]:NEEDS[UniversalStorage2]:FOR[zzz_ChemicalPropulsion]
{
	@MODULE[USFuelSwitch]:HAS[#chemTechUSFuelSwitch[true]]
	{
		@chemTechUSVolume1 *= 9						// = 320 * 9 = 2880

		chemTechUSXenonCost = #$chemTechUSVolume1$	// = 2880
		@chemTechUSXenonCost *= 4					// = 2880 * 4 = 11520
		@chemTechUSCost1 += #$chemTechUSXenonCost$	// = 31 + 11520 = 11551
		@chemTechUSCost2 += #$chemTechUSXenonCost$
		@chemTechUSCost2 += #$chemTechUSXenonCost$	// = 531 + (2 * 11520) = 23571
		@chemTechUSCost3 += #$chemTechUSXenonCost$
		@chemTechUSCost3 += #$chemTechUSXenonCost$
		@chemTechUSCost3 += #$chemTechUSXenonCost$	// = 1031 + (3 * 11520) = 35591

		// at this point, chemTechUSCost4 = 1531, chemTechUSVolume4 = 1280
		// this line seems to price the largest Xenon tank, filled with Xenon, as if it was empty?
-->		@tankCost = #$tankCost$|$chemTechUSCost1$;$chemTechUSCost2$;$chemTechUSCost3$;$chemTechUSCost4$
	}
	@MODULE[USSwitchControl]:HAS[#chemTechUSSwitchControl[true]]
	{
		@ObjectNames = #$ObjectNames$;#LOC_ChemicalCore_XenonGas_title
		@VariantColors = #$VariantColors$;#a1a1a1,#fffb69
	}
}

[CharleRoger]

@jvosk your finds here are unrelated to this case, but were indeed issues which are fixed in 1.6.1.

The original issue highlighted here is that apparently Universal Storage II's mesh switch doesn't like duplicate subtypes using the same mesh, which I was somehow totally unaware of till now (I guess I must have barely tested this patch). This is basically impossible for me to straightforwardly get around, so unfortunately this bug will have to remain until I have a good idea.