MM patching errors with Karibou and USI Kontainers

[JonnyOThan]

These mods contain incorrect FSFuelSwitch patches that contain a comma:

KER_Adapter.cfg:

	MODULE
	{
		name = FSfuelSwitch
		resourceNames =LiquidFuel,Oxidizer;Water;Chemicals;Organics;Mulch;LqdHydrogen;LiquidFuel;MonoPropellant;MetallicOre;Uraninite;Substrate;Minerals;Karbonite;ExoticMinerals,RareMetals;RocketParts;Metals;EnrichedUranium,DepletedUranium;Polymers;Supplies;Ore;Machinery;Recyclables;SpecializedParts;Fertilizer
		resourceAmounts = 112.5,137.5;1250;1250;1250;1250;1250;250;250;1250;1250;1250;1250;1250;625,625;250;1250;625,625;1250;1250;250;1250;1250;1250;1250
		initialResourceAmounts = 0;0;0;0;0;0;0;0;0;0;0;0;0;0,0;0;0;0,0;0;0;0;0;0;0;0
		tankCost = 500;500;20000;1000;500;500;500;750;3500;2500;2000;2500;2000;163500;2500;19000;541500;11000;19500;300;25000;12500;50000;7000
		basePartMass = 1
		tankMass = 0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0
		hasGUI = false
	}

That then triggers MM patching errors because the regexes here can't deal with it:

ChemicalPropulsion/GameData/ChemicalPropulsion/Patches/Compatibility/chemical-propulsion-Firespitter.cfg

Line 32 in dc3672e

@chemTechTankVolumeFuelOxidizer ^= :^[^;]+;\s*([^;]+).*$:$1:

I'm not sure if FSFuelSwitch treats commas and semicolons the same?

[LOG 13:53:03.540] Applying update ChemicalPropulsion/Patches/Compatibility/chemical-propulsion-Firespitter/@PART:HAS[!RESOURCE[LiquidFuel],!RESOURCE[LqdHydrogen],!RESOURCE[LqdMethane],!RESOURCE[Oxidizer],@MODULE[FSfuelSwitch]:HAS[#resourceNames[LiquidFuel,Oxidizer*]]]:NEEDS[Firespitter]:FOR[zz_ChemicalPropulsion] to UmbraSpaceIndustries/Karibou/Parts/KER_Adapter.cfg/PART[KER_Adapter]
[ERR 13:53:03.542] Error - Failed to do a maths replacement: @PART:HAS[!RESOURCE[LiquidFuel],!RESOURCE[LqdHydrogen],!RESOURCE[LqdMethane],!RESOURCE[Oxidizer],@MODULE[FSfuelSwitch]:HAS[#resourceNames[LiquidFuel,Oxidizer*]]]:NEEDS[Firespitter]:FOR[zz_ChemicalPropulsion] : original value="225,275" operator=Multiply mod value="5"
[LOG 13:53:03.545] Applying update ChemicalPropulsion/Patches/Compatibility/chemical-propulsion-Firespitter/@PART:HAS[!RESOURCE[LiquidFuel],!RESOURCE[LqdHydrogen],!RESOURCE[LqdMethane],!RESOURCE[Oxidizer],@MODULE[FSfuelSwitch]:HAS[#resourceNames[LiquidFuel,Oxidizer*]]]:NEEDS[Firespitter]:FOR[zz_ChemicalPropulsion] to UmbraSpaceIndustries/Karibou/Parts/KER_Tank.cfg/PART[KER_Tank]
[ERR 13:53:03.545] Error - Failed to do a maths replacement: @PART:HAS[!RESOURCE[LiquidFuel],!RESOURCE[LqdHydrogen],!RESOURCE[LqdMethane],!RESOURCE[Oxidizer],@MODULE[FSfuelSwitch]:HAS[#resourceNames[LiquidFuel,Oxidizer*]]]:NEEDS[Firespitter]:FOR[zz_ChemicalPropulsion] : original value="225,275" operator=Multiply mod value="5"
[LOG 13:53:03.546] Applying update ChemicalPropulsion/Patches/Compatibility/chemical-propulsion-Firespitter/@PART:HAS[!RESOURCE[LiquidFuel],!RESOURCE[LqdHydrogen],!RESOURCE[LqdMethane],!RESOURCE[Oxidizer],@MODULE[FSfuelSwitch]:HAS[#resourceNames[LiquidFuel,Oxidizer*]]]:NEEDS[Firespitter]:FOR[zz_ChemicalPropulsion] to UmbraSpaceIndustries/Karibou/Parts/KER_WheelBay.cfg/PART[KER_WheelBay]
[ERR 13:53:03.547] Error - Failed to do a maths replacement: @PART:HAS[!RESOURCE[LiquidFuel],!RESOURCE[LqdHydrogen],!RESOURCE[LqdMethane],!RESOURCE[Oxidizer],@MODULE[FSfuelSwitch]:HAS[#resourceNames[LiquidFuel,Oxidizer*]]]:NEEDS[Firespitter]:FOR[zz_ChemicalPropulsion] : original value="900,1100" operator=Multiply mod value="5"
[LOG 13:53:03.547] Applying update ChemicalPropulsion/Patches/Compatibility/chemical-propulsion-Firespitter/@PART:HAS[!RESOURCE[LiquidFuel],!RESOURCE[LqdHydrogen],!RESOURCE[LqdMethane],!RESOURCE[Oxidizer],@MODULE[FSfuelSwitch]:HAS[#resourceNames[LiquidFuel,Oxidizer*]]]:NEEDS[Firespitter]:FOR[zz_ChemicalPropulsion] to UmbraSpaceIndustries/Karibou/Parts/KER_WheelBay_Short.cfg/PART[KER_WheelBay_Short]
[ERR 13:53:03.548] Error - Failed to do a maths replacement: @PART:HAS[!RESOURCE[LiquidFuel],!RESOURCE[LqdHydrogen],!RESOURCE[LqdMethane],!RESOURCE[Oxidizer],@MODULE[FSfuelSwitch]:HAS[#resourceNames[LiquidFuel,Oxidizer*]]]:NEEDS[Firespitter]:FOR[zz_ChemicalPropulsion] : original value="450,550" operator=Multiply mod value="5"
[LOG 13:53:03.559] Applying update ChemicalPropulsion/Patches/Compatibility/chemical-propulsion-Firespitter/@PART:HAS[!RESOURCE[LiquidFuel],!RESOURCE[LqdHydrogen],!RESOURCE[LqdMethane],!RESOURCE[Oxidizer],@MODULE[FSfuelSwitch]:HAS[#resourceNames[LiquidFuel,Oxidizer*]]]:NEEDS[Firespitter]:FOR[zz_ChemicalPropulsion] to UmbraSpaceIndustries/Kontainers/Parts/MountableLqdTank.cfg/PART[MountableLqdTank]
[ERR 13:53:03.560] Error - Failed to do a maths replacement: @PART:HAS[!RESOURCE[LiquidFuel],!RESOURCE[LqdHydrogen],!RESOURCE[LqdMethane],!RESOURCE[Oxidizer],@MODULE[FSfuelSwitch]:HAS[#resourceNames[LiquidFuel,Oxidizer*]]]:NEEDS[Firespitter]:FOR[zz_ChemicalPropulsion] : original value="49.5,60.5" operator=Multiply mod value="5"
[LOG 13:53:03.561] Applying update ChemicalPropulsion/Patches/Compatibility/chemical-propulsion-Firespitter/@PART:HAS[!RESOURCE[LiquidFuel],!RESOURCE[LqdHydrogen],!RESOURCE[LqdMethane],!RESOURCE[Oxidizer],@MODULE[FSfuelSwitch]:HAS[#resourceNames[LiquidFuel,Oxidizer*]]]:NEEDS[Firespitter]:FOR[zz_ChemicalPropulsion] to UmbraSpaceIndustries/Kontainers/Parts/RadialLqdTank.cfg/PART[RadialLqdTank]
[ERR 13:53:03.561] Error - Failed to do a maths replacement: @PART:HAS[!RESOURCE[LiquidFuel],!RESOURCE[LqdHydrogen],!RESOURCE[LqdMethane],!RESOURCE[Oxidizer],@MODULE[FSfuelSwitch]:HAS[#resourceNames[LiquidFuel,Oxidizer*]]]:NEEDS[Firespitter]:FOR[zz_ChemicalPropulsion] : original value="112.5,137.5" operator=Multiply mod value="5"

It looks like it does do something with a comma, but I haven't fully teased out what: https://github.com/snjo/Firespitter/blob/de3fcf0ba10ef079b03e3fe56878e6101a038bf7/Firespitter/customization/FSfuelSwitch.cs#L285

[CharleRoger]

The patch is correct for what I designed it to do but does not handle this case. I am aware of this and know how to fix it, just haven't got round to it yet. FSFuelSwitch has always been and continues to be an absolute pain to deal with.