Reject multiline chat messages attempting to watch/blacklist keywords #12736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoconutMacaroon
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12732 by telling the user
I tested this in a separate chatroom here, and testing a multiline watch that would exceed the normal length limit produced an error.
However, a short multiline watch (chat link) produced no response; however, doing so also didn't appear to break anything. Of course, silently ignoring a command isn't exactly ideal either, so that needs either:Someone to say "Eh, good enough"Or I should figure out why that happens and fix itSee this section of transcript regarding the crossed-out text above. I didn't have time to finish investigating that, but the short version is this:
It wasn't caused by this change (it's reproducible with unmodified SmokeDetector). I suspect it's related to these lines of code (specifics here), but I haven't finished investigating it and haven't confirmed that's the root cause.