Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeletionWatcher: answers are never re-watched upon reboot #11539

Closed
makyen opened this issue Jun 16, 2024 · 2 comments
Closed

DeletionWatcher: answers are never re-watched upon reboot #11539

makyen opened this issue Jun 16, 2024 · 2 comments
Labels
area: DeletionWatcher status: confirmed Confirmed as something that needs working on. type: bug Aaaah! Kill it!

Comments

@makyen
Copy link
Contributor

makyen commented Jun 16, 2024

Rewatching an answer upon reboot currently depends on GlobalVars.post_site_id_to_question[post_site_id] to have the question ID for the answer. That is only populated in spamhandling.py and is not stored persistently (i.e., it's empty upon reboot). It would be better to store the question ID in the datawatcher pickle, so it doesn't need to be discovered upon reboot (and the question ID isn't available from the SE API unless there's at least one comment (it's available in the link provided for the comment).

@makyen makyen added type: bug Aaaah! Kill it! area: DeletionWatcher status: confirmed Confirmed as something that needs working on. labels Jun 16, 2024
@codygray
Copy link
Member

codygray commented Sep 7, 2024

Is this now closed, with the merging of #11839?

@makyen
Copy link
Contributor Author

makyen commented Sep 7, 2024

@codygray No, that PR explicitly doesn't resolve this issue, #11539, or #11540.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: DeletionWatcher status: confirmed Confirmed as something that needs working on. type: bug Aaaah! Kill it!
Development

No branches or pull requests

2 participants