Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regex for auto-generated MS searches. #13814

Closed
wants to merge 2 commits into from

Conversation

Andrew5057
Copy link

@Andrew5057 Andrew5057 commented Nov 21, 2024

Add "body_is_regex=1" to the MS searches that SmokeDetector automatically creates for new PRs. Should resolve #10228.

Not tested yet - I was planning to, but I didn't want to remove the self-prompting filter in my SD fork, and my sock puppet doesn't have enough rep to use chat yet.

Andrew5057 and others added 2 commits November 20, 2024 20:54
Add "body_is_regex=1" to the MS searches that SmokeDetector
automatically creates for new PRs. Should resolve
[Charcoal-SE#10228](Charcoal-SE#10228).
@Andrew5057
Copy link
Author

Andrew5057 commented Nov 21, 2024

Actually, there's already some code to handle this in gitmanager.py. Not sure if this PR is still needed, but it definitely needs work.

@Andrew5057 Andrew5057 closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Generated MS search lacks body_is_regex=1
1 participant