Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alternative dimensions for margins #51

Open
mvarendorff2 opened this issue Dec 6, 2024 · 0 comments
Open

Support alternative dimensions for margins #51

mvarendorff2 opened this issue Dec 6, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@mvarendorff2
Copy link

Currently it is only possible to specify the margin dimensions as a double which gotenberg by default interprets as inches. However gotenberg also supports specifying the units e.g. 75px which I think would be a very useful addition to this library (I just ran into the pitfall of assuming it would be pixels, accidentally specifying 200in margins while converting some older code).

@Jaben Jaben self-assigned this Dec 9, 2024
@Jaben Jaben added the enhancement New feature or request label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants