Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AddBlock using translated shim type backed by Ext #4466

Open
timwu20 opened this issue Jan 14, 2025 · 0 comments
Open

Implement AddBlock using translated shim type backed by Ext #4466

timwu20 opened this issue Jan 14, 2025 · 0 comments

Comments

@timwu20
Copy link
Contributor

timwu20 commented Jan 14, 2025

Issue Summary

Taken from design doc:

Given that storing a block and it's associated storage changes are handled in one BlockImportOperation, we should remove the StoreTrie method entirely from StorageState. Rather BlockState.AddBlock should accept an introduced OverlayedChanges type analogous to the substrate primitive.

Acceptance Criteria

  • Modify AddBlock method in BlockState interface to accept OverlayedChanges
  • Implement AddBlock method in translation shim to take OverlayedChanges. Eventually call BlockImport methods from issue Implement BlockImport interface for Client type #4458 to taken in parent block hash, and storage changes from OverlayedChanges to import block.
  • Unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant