Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Kolmgorov stepper #67

Open
Ceyron opened this issue Nov 5, 2024 · 1 comment
Open

Validate Kolmgorov stepper #67

Ceyron opened this issue Nov 5, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Ceyron
Copy link
Owner

Ceyron commented Nov 5, 2024

Ensure the spectrum is comparable in the validation/validate_kolmogorov_spectrum.ipynb notebook. It could be that these lines

self.injection = jnp.where(
injection_mask,
# Need to additional scale the `injection_scale` with the
# `injection_mode`, because we apply the forcing on the vorticity.
-injection_mode
* injection_scale
* build_scaling_array(num_spatial_dims, num_points, mode="coef_extraction"),
0.0,
)

cause a wrong scaling in the injected energy. This could be related to #34

@Ceyron Ceyron added the bug Something isn't working label Nov 5, 2024
@Ceyron Ceyron self-assigned this Nov 5, 2024
@Ceyron
Copy link
Owner Author

Ceyron commented Nov 5, 2024

@GeorgKohl also worked with this stepper. Linking him here for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant