You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So it might be trivial to add this for someone who knows the right place.
Running eslint with --report-unused-disable-directives currently generates 149 messages 😬 But it looks like they can all be fixed automatically with --fix. So this could easily be done as a one-shot cleanup.
(Some of them are about to be fixed as part of another PR, so it could make sense for this PR to be merged before doing that cleanup pass)
The text was updated successfully, but these errors were encountered:
There are a few
eslint-disable...
directives that are unused. They are detected by VSCode, but apparently, don't cause any problem in CI:One way to check for them is to change the
eslint
call to include--report-unused-disable-directives
, as in"eslint": "eslint \"./**/*.*js\" \"./**/*.html\" --cache --quiet --report-unused-disable-directives",
But preferably, this should be included somewhere in https://github.com/CesiumGS/eslint-config-cesium .
The documentation mentions this:
So it might be trivial to add this for someone who knows the right place.
Running
eslint
with--report-unused-disable-directives
currently generates 149 messages 😬 But it looks like they can all be fixed automatically with--fix
. So this could easily be done as a one-shot cleanup.(Some of them are about to be fixed as part of another PR, so it could make sense for this PR to be merged before doing that cleanup pass)
The text was updated successfully, but these errors were encountered: