Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDR Tonemap Modified Reinhard equation possibly wrong #12175

Open
jjspace opened this issue Aug 30, 2024 · 0 comments
Open

HDR Tonemap Modified Reinhard equation possibly wrong #12175

jjspace opened this issue Aug 30, 2024 · 0 comments

Comments

@jjspace
Copy link
Contributor

jjspace commented Aug 30, 2024

I think the current equation for our Modified Reinhard tonemap is slightly wrong

color = (color * (1.0 + color / white)) / (1.0 + color);

The original source link seems to no longer exist but judging by these other articles I found the color / white should be color / (white * white)

This hasn't been touched since the initial HDR PR (#7017) so I don't know the context here that might dictate this as intentional.

This came up during #12160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant