Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prettier #12172

Closed
jjspace opened this issue Aug 29, 2024 · 2 comments · Fixed by #12206
Closed

Update prettier #12172

jjspace opened this issue Aug 29, 2024 · 2 comments · Fixed by #12206
Assignees
Labels
category - node / npm dependencies Relating to our package dependencies

Comments

@jjspace
Copy link
Contributor

jjspace commented Aug 29, 2024

Prettier has been bumped a major version, v3.0.0 and multiple versions after, up to v3.3.0 at time of writing. We're still on v2.1.2. We should probably do a push to update and address all breaking changes at once so we're closer to in sync and future updates are smaller. I just don't want to do that right before a release.
I think the biggest rule change that I know about is that trailing commas now default to all which will probably result in a very large PR of small, non functional, differences. They also changed some logic about how long lines wrap to make things readable and waste less vertical space which will probably affect most of our files.

@jjspace jjspace added category - tooling dependencies Relating to our package dependencies labels Aug 29, 2024
@jjspace jjspace mentioned this issue Aug 29, 2024
6 tasks
@dave-b-b
Copy link

dave-b-b commented Sep 2, 2024

I'll take this one if it is still available.

@ggetz
Copy link
Contributor

ggetz commented Sep 3, 2024

@jjspace Would you be able to advise @dave-b-b on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - node / npm dependencies Relating to our package dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants