Skip to content

FEAT/MM-191 모달 화면 표기되도록 추가 개발 및 애니메이션 수정#88

Merged
hin6150 merged 5 commits into
devfrom
feat/MM-191
Mar 27, 2026
Merged

FEAT/MM-191 모달 화면 표기되도록 추가 개발 및 애니메이션 수정#88
hin6150 merged 5 commits into
devfrom
feat/MM-191

Conversation

@hin6150
Copy link
Copy Markdown
Member

@hin6150 hin6150 commented Mar 26, 2026

이슈 번호

#MM-191

작업내용

  • 변경한 주요 내용 목록
    • 애니메이션 방향 강제 지정할 수 있게 개선
    • 업데이트 모달 화면 추가개발

리뷰어에게 전할 말

스크린샷 (선택사항)

hin6150 and others added 4 commits March 26, 2026 22:38
REPLACE 액션이 항상 forward로 판정되어 역방향 애니메이션이 재생되던 문제 수정.
navigate state에 forceDirection을 추가하여 REPLACE 이동 시에도 방향을 명시적으로 지정할 수 있도록 개선.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- 업데이트일로부터 7일간 전체 유저 대상 모달 노출
- X 버튼 및 '기대돼요!' 버튼으로 닫기, 이후 재노출 없음
- dismissed 상태를 bridge를 통해 native(SecureStore)에 저장
- 웹 환경 fallback은 localStorage 사용

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@hin6150 hin6150 requested a review from LeeWxx March 26, 2026 13:44
@hin6150 hin6150 self-assigned this Mar 26, 2026
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 사용자에게 성향 테스트 리뉴얼을 알리는 새로운 모달 화면을 추가하고, 내비게이션 시 애니메이션 방향을 강제로 지정할 수 있도록 기능을 개선합니다. 이를 통해 사용자 경험을 향상시키고, 특정 내비게이션 흐름에서 애니메이션 동작을 보다 세밀하게 제어할 수 있게 됩니다.

Highlights

  • 새로운 '성향 리뉴얼 모달' 기능 추가: 사용자에게 성향 테스트 리뉴얼을 알리는 새로운 모달 화면이 추가되었습니다.
  • 모달 '확인됨' 상태 영구 저장: 모달의 '확인됨' 상태를 AuthStoragelocalStorage를 사용하여 영구적으로 저장하는 기능이 구현되었습니다.
  • 메인 페이지에 모달 통합: 메인 애플리케이션 페이지에 성향 리뉴얼 모달이 통합되어 적절한 시점에 사용자에게 표시됩니다.
  • 내비게이션 애니메이션 방향 제어 개선: 내비게이션 시 애니메이션 방향을 강제로 지정할 수 있도록 히스토리 상태에 forceDirection 옵션이 추가되었습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new 'Personality Renewal Modal' feature. It adds new bridge methods and AuthStorage functionality to manage the modal's seen state, and integrates the modal into the main application page. Additionally, it updates navigation logic to support forceDirection for specific routes. Review comments highlight that the UPDATE_DATE for the modal is set to 2026, which might be an unintended future date or should be explicitly marked as a test value. Another issue noted is that the AlertDialog's onOpenChange prop is undefined, preventing the modal from closing via external clicks or the Escape key, which impacts user experience.

@hin6150 hin6150 merged commit 7988ad2 into dev Mar 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant