FEAT/MM-191 모달 화면 표기되도록 추가 개발 및 애니메이션 수정#88
Conversation
REPLACE 액션이 항상 forward로 판정되어 역방향 애니메이션이 재생되던 문제 수정. navigate state에 forceDirection을 추가하여 REPLACE 이동 시에도 방향을 명시적으로 지정할 수 있도록 개선. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- 업데이트일로부터 7일간 전체 유저 대상 모달 노출 - X 버튼 및 '기대돼요!' 버튼으로 닫기, 이후 재노출 없음 - dismissed 상태를 bridge를 통해 native(SecureStore)에 저장 - 웹 환경 fallback은 localStorage 사용 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 사용자에게 성향 테스트 리뉴얼을 알리는 새로운 모달 화면을 추가하고, 내비게이션 시 애니메이션 방향을 강제로 지정할 수 있도록 기능을 개선합니다. 이를 통해 사용자 경험을 향상시키고, 특정 내비게이션 흐름에서 애니메이션 동작을 보다 세밀하게 제어할 수 있게 됩니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'Personality Renewal Modal' feature. It adds new bridge methods and AuthStorage functionality to manage the modal's seen state, and integrates the modal into the main application page. Additionally, it updates navigation logic to support forceDirection for specific routes. Review comments highlight that the UPDATE_DATE for the modal is set to 2026, which might be an unintended future date or should be explicitly marked as a test value. Another issue noted is that the AlertDialog's onOpenChange prop is undefined, preventing the modal from closing via external clicks or the Escape key, which impacts user experience.
이슈 번호
작업내용
리뷰어에게 전할 말
스크린샷 (선택사항)