Stop suppressing warnings around the session constructor

warnings.catch_warnings swaps the module-global filter list, not a thread-local
one, so the window silently dropped every other thread's DeprecationWarning for
the duration of the construction. Keeping it cost more than the duplicate
warning it hid, and the two warnings are not redundant: one names the factory
the caller used, the other the class it keeps using afterwards.

Without it the method body is main's again, and warnings is no longer imported.

Signed-off-by: Honglin Cao <hocao@nvidia.com>

Author: V2arK

centml/sdk/api.py

@@ -1,5 +1,4 @@
 import time
-import warnings
 from bisect import insort
 from contextlib import contextmanager
 from dataclasses import dataclass
@@ -502,11 +501,7 @@ def deployment_log_session(
         Stateful reader for one pod's logs that tracks fetched pages and anchors
         every request itself — see DeploymentLogSession. Seed events with logs a
         previous session (or get_deployment_logs) returned for the same pod."""
-        with warnings.catch_warnings():
-            # This call already warned via its own decorator; constructing the
-            # (also-deprecated) session class must not warn a second time.
-            warnings.simplefilter("ignore", DeprecationWarning)
-            return DeploymentLogSession(self, deployment_id, revision_number, pod, events)
+        return DeploymentLogSession(self, deployment_id, revision_number, pod, events)
 
 
 @deprecated("DeploymentLogSession is deprecated; use CentMLClient.fetch_logs() instead")

tests/test_sdk_api.py

@@ -1051,9 +1051,12 @@ def test_deprecated_log_readers_warn_and_name_the_replacement():
         client.get_deployment_logs_range(123, 2)
     with pytest.warns(DeprecationWarning, match="fetch_logs") as caught:
         session = client.deployment_log_session(123, 2, "pod-a")
-    # Exactly one warning: the method's own, not a second from constructing the
-    # (also-deprecated) session class inside it.
-    assert len(caught) == 1
+    # Two warnings, one per deprecated surface the call crosses: the factory the
+    # caller named, and the session class it hands back for the caller to keep using.
+    assert [str(warning.message) for warning in caught] == [
+        "deployment_log_session() is deprecated; use fetch_logs() instead",
+        "DeploymentLogSession is deprecated; use CentMLClient.fetch_logs() instead",
+    ]
     with pytest.warns(DeprecationWarning, match="fetch_logs"):
         DeploymentLogSession(client, 123, 2, "pod-a")