Merge pull request #55 from CastQuest/copilot/fix-typescript-errors-core-services

Fix TypeScript compilation errors in core-services package

Author: SMSDAO

packages/core-services/package.json

@@ -17,35 +17,36 @@
     "db:reset": "tsx src/lib/db/reset.ts"
   },
   "dependencies": {
-    "express": "^4.18.2",
+    "bcrypt": "^5.1.1",
     "cors": "^2.8.5",
-    "helmet": "^7.1.0",
-    "express-rate-limit": "^7.1.5",
-    "pg": "^8.11.3",
+    "dotenv": "^16.3.1",
     "drizzle-orm": "^0.29.3",
-    "zod": "^3.22.4",
+    "express": "^4.18.2",
+    "express-rate-limit": "^7.1.5",
+    "helmet": "^7.1.0",
     "jsonwebtoken": "^9.0.2",
-    "bcrypt": "^5.1.1",
     "nodemailer": "^6.9.8",
+    "pg": "^8.11.3",
     "viem": "^2.7.6",
-    "dotenv": "^16.3.1",
-    "winston": "^3.11.0"
+    "winston": "^3.11.0",
+    "zod": "^3.22.4"
   },
   "devDependencies": {
-    "@types/express": "^4.17.21",
+    "@types/bcrypt": "^5.0.2",
     "@types/cors": "^2.8.17",
-    "@types/node": "^20.10.6",
+    "@types/express": "^4.17.21",
     "@types/jsonwebtoken": "^9.0.5",
-    "@types/bcrypt": "^5.0.2",
+    "@types/node": "^20.10.6",
     "@types/nodemailer": "^6.4.14",
-    "tsx": "^4.7.0",
-    "typescript": "^5.3.3",
-    "tsc-alias": "^1.8.8",
-    "vitest": "^1.1.1",
-    "eslint": "^8.56.0",
+    "@types/pg": "^8.16.0",
     "@typescript-eslint/eslint-plugin": "^6.18.0",
     "@typescript-eslint/parser": "^6.18.0",
-    "drizzle-kit": "^0.20.9"
+    "drizzle-kit": "^0.20.9",
+    "eslint": "^8.56.0",
+    "tsc-alias": "^1.8.8",
+    "tsx": "^4.7.0",
+    "typescript": "^5.3.3",
+    "vitest": "^1.1.1"
   },
   "keywords": [
     "castquest",

packages/core-services/src/index.ts

@@ -25,7 +25,7 @@ export { logger } from './lib/logger';
 export { authenticateAdmin, authenticateJWT, optionalAuth } from './lib/middleware/auth';
 
 // Export services (for direct usage in other packages)
-export { MarketService } from './modules/markets/service';
+export { MarketsService } from './modules/markets/service';
 export { MediaService } from './modules/media/service';
 export { RiskService } from './modules/risk/service';
 export { UserService } from './modules/users/service';

packages/core-services/src/lib/db/index.ts

@@ -15,7 +15,7 @@ pool.on('connect', () => {
   logger.info('Database connection established');
 });
 
-pool.on('error', (err) => {
+pool.on('error', (err: Error) => {
   logger.error('Database connection error:', err);
 });
 

packages/core-services/src/lib/db/schema.ts

@@ -185,6 +185,7 @@ export const riskAssessments = pgTable('risk_assessments', {
   id: uuid('id').primaryKey().defaultRandom(),
   tokenAddress: text('token_address').notNull(),
   riskScore: integer('risk_score').notNull(),
+  riskLevel: text('risk_level'), // low, medium, high, critical
   confidence: integer('confidence').notNull(),
   flags: text('flags').array().notNull(),
   reasons: text('reasons').array().notNull(),

packages/core-services/src/modules/risk/routes.ts

@@ -2,7 +2,7 @@ import { Request, Response, Router } from 'express';
 import { z } from 'zod';
 import { RiskService } from './service';
 
-export const riskRoutes = Router();
+export const riskRoutes: Router = Router();
 const riskService = new RiskService();
 
 // Validation schemas

packages/core-services/src/modules/risk/service.ts

@@ -18,8 +18,13 @@ export class RiskService {
     const [assessment] = await db
       .insert(riskAssessments)
       .values({
-        ...data,
         tokenAddress: data.tokenAddress.toLowerCase(),
+        riskScore: data.riskScore,
+        riskLevel: data.riskLevel,
+        confidence: 85, // Default confidence level
+        flags: data.recommendations, // Map recommendations to flags
+        reasons: data.recommendations, // Map recommendations to reasons
+        assessedBy: data.assessedBy,
         assessedAt: new Date(),
       })
       .returning();
@@ -33,7 +38,7 @@ export class RiskService {
       })
       .where(eq(mediaMetadata.tokenAddress, data.tokenAddress.toLowerCase()));
 
-    return assessment;
+    return assessment as RiskAssessment;
   }
 
   /**
@@ -47,7 +52,7 @@ export class RiskService {
       .orderBy(desc(riskAssessments.assessedAt))
       .limit(1);
 
-    return assessment || null;
+    return (assessment as RiskAssessment) || null;
   }
 
   /**
@@ -64,7 +69,7 @@ export class RiskService {
       .where(eq(riskAssessments.tokenAddress, tokenAddress.toLowerCase()))
       .orderBy(desc(riskAssessments.assessedAt))
       .limit(limit)
-      .offset(offset);
+      .offset(offset) as Promise<RiskAssessment[]>;
   }
 
   /**
@@ -77,7 +82,7 @@ export class RiskService {
       .where(gte(riskAssessments.riskScore, 70))
       .orderBy(desc(riskAssessments.riskScore), desc(riskAssessments.assessedAt))
       .limit(limit)
-      .offset(offset);
+      .offset(offset) as Promise<RiskAssessment[]>;
   }
 
   /**
@@ -94,7 +99,7 @@ export class RiskService {
       .where(eq(riskAssessments.riskLevel, riskLevel))
       .orderBy(desc(riskAssessments.assessedAt))
       .limit(limit)
-      .offset(offset);
+      .offset(offset) as Promise<RiskAssessment[]>;
   }
 
   /**
@@ -231,7 +236,9 @@ export class RiskService {
     };
 
     levelCounts.forEach((row) => {
-      byLevel[row.level] = row.count;
+      if (row.level) {
+        byLevel[row.level] = row.count;
+      }
     });
 
     // Get average risk score
@@ -250,7 +257,7 @@ export class RiskService {
       .from(mediaMetadata);
 
     return {
-      totalAssessments: Object.values(byLevel).reduce((a: number, b: number) => a + b, 0),
+      totalAssessments: (Object.values(byLevel) as number[]).reduce((a, b) => a + b, 0),
       byLevel,
       averageRiskScore: parseFloat(avgScore?.avg?.toString() || '0'),
       flaggedCount: statusCounts?.flagged || 0,

packages/core-services/src/modules/users/routes.ts

@@ -3,7 +3,7 @@ import { Request, Response, Router } from 'express';
 import { z } from 'zod';
 import { UserService } from './service';
 
-const router = Router();
+const router: Router = Router();
 const userService = new UserService();
 
 // ============================================================================

packages/core-services/src/modules/users/service.ts

@@ -87,10 +87,12 @@ export class UserService {
       .where(eq(users.id, user.id));
 
     // Generate JWT
+    const jwtSecret = config.auth.jwtSecret as string;
+    const jwtExpiresIn = config.auth.jwtExpiresIn as string;
     const token = jwt.sign(
       { userId: user.id, email: user.email },
-      config.auth.jwtSecret,
-      { expiresIn: config.auth.jwtExpiresIn }
+      jwtSecret,
+      { expiresIn: jwtExpiresIn } as jwt.SignOptions
     );
 
     logger.info(`User logged in: ${user.id}`);

packages/core-services/src/modules/wallets/routes.ts

@@ -3,7 +3,7 @@ import { Request, Response, Router } from 'express';
 import { z } from 'zod';
 import { WalletService } from './service';
 
-const router = Router();
+const router: Router = Router();
 const walletService = new WalletService();
 
 // ============================================================================

packages/core-services/src/types/index.ts

@@ -178,23 +178,35 @@ export interface Trade {
 // Risk & Abuse Domain
 // ============================================================================
 
+export type RiskFlag = 
+  | 'WASH_TRADING'
+  | 'PUMP_AND_DUMP'
+  | 'LOW_LIQUIDITY'
+  | 'SUSPICIOUS_VOLUME'
+  | 'PRICE_MANIPULATION'
+  | 'SPAM_TOKEN'
+  | 'RUG_PULL_RISK'
+  | 'HONEYPOT'
+  | 'HIGH_CONCENTRATION'
+  | 'nsfw'
+  | 'spam'
+  | 'copyright'
+  | 'scam'
+  | 'duplicate'
+  | 'low_quality';
+
 export interface RiskAssessment {
+  id?: string;
   tokenAddress: string;
   riskScore: number; // 0-100
   confidence: number; // 0-100
-  flags: RiskFlag[];
+  flags: string[]; // Array of RiskFlag strings
   reasons: string[];
+  riskLevel?: 'low' | 'medium' | 'high' | 'critical' | null;
   assessedAt: Date;
   assessedBy: 'ai' | 'moderator' | 'community';
 }
 
-export interface RiskFlag {
-  type: 'nsfw' | 'spam' | 'copyright' | 'scam' | 'duplicate' | 'low_quality';
-  severity: 'low' | 'medium' | 'high' | 'critical';
-  confidence: number;
-  details?: string;
-}
-
 export interface RateLimit {
   identifier: string; // IP or userId
   endpoint: string;