Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the input arg type for resolve_session and check_resolve_session #140

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Fix the input arg type for resolve_session and check_resolve_session #140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a87200
fix [check_]resolve_session input type
hemidactylus Feb 8, 2024
f85a125
bring main
hemidactylus Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cassio/config/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,15 +305,15 @@ def init(
shutil.rmtree(temp_dir)


def resolve_session(arg_session: Optional[str] = None) -> Optional[Session]:
def resolve_session(arg_session: Optional[Session] = None) -> Optional[Session]:
"""Utility to fall back to the global defaults when null args are passed."""
if arg_session is not None:
return arg_session
else:
return default_session


def check_resolve_session(arg_session: Optional[str] = None) -> Session:
def check_resolve_session(arg_session: Optional[Session] = None) -> Session:
s = resolve_session(arg_session)
if s is None:
raise ValueError("DB session not set.")
Expand Down
Loading