Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix typos #7

wants to merge 2 commits into from

Conversation

EliasJRH
Copy link
Contributor

@EliasJRH EliasJRH commented Dec 4, 2024

Closes #3

This PR just updates the multicast address and corrects pressure to be a signed 32-bit integer.

@EliasJRH EliasJRH requested a review from linguini1 December 4, 2024 03:39
Copy link
Collaborator

@linguini1 linguini1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this gets merged, please open an issue to use signed pressure values on hysim.

@@ -61,7 +61,7 @@ \subsection{Pressure} \label{sec:pressure}
\textbf{Time:} A time stamp measured in milliseconds since the system received power. This field is an unsigned 32-bit
integer.

\textbf{Pressure} Pressure measured in thousandths of PSI (milli-PSI). This field is an unsigned 32-bit integer.
\textbf{Pressure} Pressure measured in thousandths of PSI (milli-PSI). This field is an signed 32-bit integer.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressure is a signed integer
2 participants