Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Implement V2 packet spec #109

Open
EliasJRH opened this issue Nov 6, 2024 · 2 comments
Open

[ENHANCEMENT] Implement V2 packet spec #109

EliasJRH opened this issue Nov 6, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@EliasJRH
Copy link
Contributor

EliasJRH commented Nov 6, 2024

Wake up babe new telemetry packet spec dropped.

Let's put all the v1 stuff in some archive folder for now. I don't think it's a bad idea to implement the spec in the same way (class structure, etc.) just to make the transition smoother.

We can also move tests to the archive and we'll need to add new tests for these packets.

Also remove the JSON matrix decoded thing.

@EliasJRH EliasJRH added the enhancement New feature or request label Nov 6, 2024
@linguini1
Copy link
Collaborator

I was gonna make the wake up babe joke! :(

Please god please remove the decoder JSON matrix thingy if you do any kind of overhaul please

@linguini1
Copy link
Collaborator

Also instead of moving to an archive folder I would recommend you just make a version release on GitHub. Then overwrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants