-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatibility with IPython >= 9.0.0 #288
Comments
guitargeek
added a commit
to guitargeek/root
that referenced
this issue
Mar 3, 2025
The newest `ipython` broke the `newest` metakernel package. See also the upstream report: Calysto/metakernel#288 Restricting the ipython version, at least until the problem is fixed upstream in the ipython/metakernel duo, will solve the problem for all ROOT branches, because the `requirements.txt` is used for all CI images. I was a bit hesitant if this is really the solution because the problem seems to be platform-dependent. However, that seems to be because ipython 9.0.0 has not reached all of pips channels yet. Compare for example these build logs: Ubuntu 24.04, picks up `ipython==8.33.0` https://productionresultssa15.blob.core.windows.net/actions-results/7a5c1f23-ff80-468b-80dd-33e4511651f6/workflow-job-run-5f5bc846-a2a7-5fbf-b892-8ca7512cbcea/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-03-03T09%3A12%3A05Z&sig=3lsuZ7wxDHR804tfJJdV0hj8o2pktHyD1cNe92gvKSI%3D&ske=2025-03-03T20%3A43%3A42Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-03-03T08%3A43%3A42Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-01-05&sp=r&spr=https&sr=b&st=2025-03-03T09%3A02%3A00Z&sv=2025-01-05 Fedora 41 picks up `ipython==9.0.0`: https://productionresultssa15.blob.core.windows.net/actions-results/7a5c1f23-ff80-468b-80dd-33e4511651f6/workflow-job-run-c55417ba-26e1-5c15-ea21-28e4787be48e/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-03-03T09%3A11%3A25Z&sig=5Q8wyCvctlAA18IQ23rJj3TAe2Sv%2FHNRrWK%2B8JZ84cI%3D&ske=2025-03-03T20%3A36%3A35Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-03-03T08%3A36%3A35Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-01-05&sp=r&spr=https&sr=b&st=2025-03-03T09%3A01%3A20Z&sv=2025-01-05
guitargeek
added a commit
to root-project/root
that referenced
this issue
Mar 3, 2025
The newest `ipython` broke the `newest` metakernel package. See also the upstream report: Calysto/metakernel#288 Restricting the ipython version, at least until the problem is fixed upstream in the ipython/metakernel duo, will solve the problem for all ROOT branches, because the `requirements.txt` is used for all CI images. I was a bit hesitant if this is really the solution because the problem seems to be platform-dependent. However, that seems to be because ipython 9.0.0 has not reached all of pips channels yet. Compare for example these build logs: Ubuntu 24.04, picks up `ipython==8.33.0` https://productionresultssa15.blob.core.windows.net/actions-results/7a5c1f23-ff80-468b-80dd-33e4511651f6/workflow-job-run-5f5bc846-a2a7-5fbf-b892-8ca7512cbcea/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-03-03T09%3A12%3A05Z&sig=3lsuZ7wxDHR804tfJJdV0hj8o2pktHyD1cNe92gvKSI%3D&ske=2025-03-03T20%3A43%3A42Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-03-03T08%3A43%3A42Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-01-05&sp=r&spr=https&sr=b&st=2025-03-03T09%3A02%3A00Z&sv=2025-01-05 Fedora 41 picks up `ipython==9.0.0`: https://productionresultssa15.blob.core.windows.net/actions-results/7a5c1f23-ff80-468b-80dd-33e4511651f6/workflow-job-run-c55417ba-26e1-5c15-ea21-28e4787be48e/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-03-03T09%3A11%3A25Z&sig=5Q8wyCvctlAA18IQ23rJj3TAe2Sv%2FHNRrWK%2B8JZ84cI%3D&ske=2025-03-03T20%3A36%3A35Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-03-03T08%3A36%3A35Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-01-05&sp=r&spr=https&sr=b&st=2025-03-03T09%3A01%3A20Z&sv=2025-01-05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Metakernel has a "hidden" dependency on IPython, hidden because it is not explicitly stated in the pyproject.toml:
metakernel/pyproject.toml
Lines 17 to 22 in 2de5d37
However, there are parts of the code that explicitly import from IPython:
metakernel/metakernel/_metakernel.py
Lines 35 to 42 in 2de5d37
This is relevant in this case because in the latest release of IPython, v9.0.0, there was a massive refactor on how colors are managed:
ipython/ipython@a796b95
This changes are backwards incompatible and make kernels derived from metakernel failed. I encounter this in the octave-kernel:
There is a need for a patch in metakernel where the version is set strictly to
IPython < 9.0.0
and a future fix where the code is refactored so that it is compatible withIPython ~= 9.0.0
The text was updated successfully, but these errors were encountered: