Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download.rvcurve requires user to omit "HD" #20

Open
bjfultn opened this issue Nov 5, 2018 · 4 comments
Open

Download.rvcurve requires user to omit "HD" #20

bjfultn opened this issue Nov 5, 2018 · 4 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request priority:high

Comments

@bjfultn
Copy link
Collaborator

bjfultn commented Nov 5, 2018

The RV CSV files have the "HD" removed from their name. If the user does not know this and simply asks to download the rvcurve for "HD185144" (for example) it will download a file which contains only an error message. The user must instead request the rvcurve for "185144".

@bjfultn bjfultn added bug Something isn't working enhancement New feature or request labels Nov 5, 2018
@bjfultn bjfultn self-assigned this Nov 5, 2018
@bjfultn
Copy link
Collaborator Author

bjfultn commented Jan 2, 2019

@JohnGood I'd like to fix this issue if possible before passing it out to CPS test users. Is this reasonable to fix in a couple days? I think this needs to happen in the idlDriver C code, but if it can be fixed at a higher level in the Python interface I'm happy to work on it myself.

@bjfultn bjfultn assigned JohnGood and unassigned bjfultn May 31, 2019
@bjfultn
Copy link
Collaborator Author

bjfultn commented May 31, 2019

@JohnGood bump on this issue while you are in there in the next couple weeks.

@bjfultn
Copy link
Collaborator Author

bjfultn commented Oct 4, 2019

This is actually no longer the case. Still lets go ahead and strip off leading HD's everywhere so that the other IDL commands are consistent with the TARGET column in the DB.

@JohnGood
Copy link
Collaborator

JohnGood commented Oct 6, 2019

I hesitate to update this right away for two reasons: Existing databases will then be wrong (though this may only affect you) and the documentation also needs to be updated. Let's promote all these changes as soon as they are all done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request priority:high
Projects
None yet
Development

No branches or pull requests

2 participants