Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pango: Build with PGO for 1.10x speedup #463

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

joebonrichie
Copy link
Contributor

Test File

https://raw.githubusercontent.com/joebonrichie/benchmarks/refs/heads/master/pango-layout-profile.c

Benchmark

hyperfine "./pango-layout-profile"
Before: 12.823 s | Now: 11.569 s

@joebonrichie
Copy link
Contributor Author

I can't actually tell whether cachy uses -O3 by default for it's own packages it provides itself over arch repos due to O3 being present in makepkg.conf. However, this in case, it causes in a performance regression so O2 is explicitly appended to build flags.

Package was benchmarked against cachyos-extra-v3/pango.

@ptr1337
Copy link
Member

ptr1337 commented Dec 28, 2024

Hey!

Thanks for the PR. I will do some testing and then will push it to the repository. PKGBUILD is looking good.

I can't actually tell whether cachy uses -O3 by default for it's own packages it provides itself over arch repos due to O3 being present in makepkg.conf. However, this in case, it causes in a performance regression so O2 is explicitly appended to build flags.

Package was benchmarked against cachyos-extra-v3/pango.

Yes, we are using currently globally -O3 - nice catch that it has a regression.

PKGBUILD Outdated Show resolved Hide resolved
PKGBUILD Outdated Show resolved Hide resolved
Test File
---------
https://raw.githubusercontent.com/joebonrichie/benchmarks/refs/heads/master/pango-layout-profile.c

Benchmark
---------
hyperfine "./pango-layout-profile"
Before: 12.823 s | Now: 11.569 s
@ptr1337 ptr1337 merged commit c745190 into CachyOS:master Dec 28, 2024
@joebonrichie joebonrichie deleted the pango-pgo branch December 28, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants