refactor testing (#34)

Author: CSharpFiasco

src/WarehouseEngine.Api/Program.cs

@@ -149,7 +149,10 @@ [new OpenApiSecuritySchemeReference("Bearer", document)] = []
             app.UseDeveloperExceptionPage();
         }
 
-        await SeedData(app.Services);
+        if (env.EnvironmentName != "Integration")
+        {
+            await SeedData(app.Services);
+        }
 
         // Configure the HTTP request pipeline.
         if (app.Environment.IsDevelopment() || app.Environment.EnvironmentName == "Integration")

tests/WarehouseEngine.Api.Integration.Tests/CustomerEndpointTests.cs

@@ -6,13 +6,11 @@
 using WarehouseEngine.Api.Integration.Tests.Factories;
 using WarehouseEngine.Application.Dtos;
 using WarehouseEngine.Application.Implementations;
-using WarehouseEngine.Domain.Entities;
 using WarehouseEngine.Domain.Models.Auth;
 using Xunit;
 
 namespace WarehouseEngine.Api.Integration.Tests;
 
-[Collection(nameof(DatabaseCollection))]
 public class CustomerEndpointTests
 {
     private readonly WarehouseEngineFactory _factory;

tests/WarehouseEngine.Api.Integration.Tests/Factories/WarehouseEngineFactory.cs

@@ -1,22 +1,15 @@
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.Mvc.Testing;
 using Microsoft.Extensions.Configuration;
+using WarehouseEngine.Api.Integration.Tests.Factories;
 using WarehouseEngine.Domain.Entities;
 using WarehouseEngine.Domain.ValueObjects;
 using WarehouseEngine.Infrastructure.DataContext;
 using Xunit;
 
-namespace WarehouseEngine.Api.Integration.Tests.Factories;
-
-[CollectionDefinition(nameof(DatabaseCollection))]
-public sealed class DatabaseCollection : ICollectionFixture<WarehouseEngineFactory>
-{
-    // Per https://xunit.net/docs/shared-context#collection-fixture
+[assembly: AssemblyFixture(typeof(WarehouseEngineFactory))]
 
-    // This class has no code, and is never created. Its purpose is simply
-    // to be the place to apply [CollectionDefinition] and all the
-    // ICollectionFixture<> interfaces.
-}
+namespace WarehouseEngine.Api.Integration.Tests.Factories;
 
 public sealed class WarehouseEngineFactory : WebApplicationFactory<Program>, IAsyncLifetime
 {

tests/WarehouseEngine.Api.Integration.Tests/VendorEndpointTests.cs

@@ -13,7 +13,6 @@
 
 namespace WarehouseEngine.Api.Integration.Tests;
 
-[Collection(nameof(DatabaseCollection))]
 public class VendorEndpointTests
 {
     private readonly WarehouseEngineFactory _factory;
@@ -308,6 +307,6 @@ public async Task OpenApi_V1Json_Success()
 
         // Verify it's valid JSON by deserializing
         var openApiDoc = JsonSerializer.Deserialize<JsonElement>(responseContent);
-        Assert.True(openApiDoc.ValueKind == JsonValueKind.Object);
+        Assert.Equal(JsonValueKind.Object, openApiDoc.ValueKind);
     }
 }