Skip to content

Commit 21d370e

Browse files
Bump SpeziFirebase to fix login transition bug (#5)
# Bump SpeziFirebase to fix login transition bug ## ⚙️ Release Notes * Bump SpeziFirebase version to fix minor regression. ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/CS342/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/CS342/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/CS342/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/CS342/.github/blob/main/CONTRIBUTING.md). --------- Co-authored-by: Paul Schmiedmayer <[email protected]>
1 parent a4778d6 commit 21d370e

File tree

5 files changed

+50
-50
lines changed

5 files changed

+50
-50
lines changed

CS342ExampleApplication.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1145,7 +1145,7 @@
11451145
repositoryURL = "https://github.com/StanfordSpezi/SpeziFirebase.git";
11461146
requirement = {
11471147
kind = upToNextMajorVersion;
1148-
minimumVersion = 2.0.0;
1148+
minimumVersion = 2.0.1;
11491149
};
11501150
};
11511151
2FE5DC8229EDD934004B9AB4 /* XCRemoteSwiftPackageReference "SpeziQuestionnaire" */ = {
@@ -1161,23 +1161,23 @@
11611161
repositoryURL = "https://github.com/StanfordSpezi/SpeziStorage.git";
11621162
requirement = {
11631163
kind = upToNextMajorVersion;
1164-
minimumVersion = 1.2.1;
1164+
minimumVersion = 1.2.3;
11651165
};
11661166
};
11671167
2FE5DC8D29EDD980004B9AB4 /* XCRemoteSwiftPackageReference "SpeziViews" */ = {
11681168
isa = XCRemoteSwiftPackageReference;
11691169
repositoryURL = "https://github.com/StanfordSpezi/SpeziViews.git";
11701170
requirement = {
11711171
kind = upToNextMajorVersion;
1172-
minimumVersion = 1.8.0;
1172+
minimumVersion = 1.9.0;
11731173
};
11741174
};
11751175
2FE5DC9029EDD9C3004B9AB4 /* XCRemoteSwiftPackageReference "firebase-ios-sdk" */ = {
11761176
isa = XCRemoteSwiftPackageReference;
11771177
repositoryURL = "https://github.com/firebase/firebase-ios-sdk.git";
11781178
requirement = {
11791179
kind = upToNextMajorVersion;
1180-
minimumVersion = 11.0.0;
1180+
minimumVersion = 11.8.0;
11811181
};
11821182
};
11831183
2FE5DC9729EDD9D9004B9AB4 /* XCRemoteSwiftPackageReference "XCTestExtensions" */ = {

CS342ExampleApplication.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 34 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

CS342ExampleApplication/Resources/Localizable.xcstrings

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@
4040
}
4141
}
4242
}
43+
},
44+
"Cats are great!" : {
45+
4346
},
4447
"Close" : {
4548
"localizations" : {
@@ -351,16 +354,6 @@
351354
}
352355
}
353356
},
354-
"The Spezi Framework" : {
355-
"localizations" : {
356-
"en" : {
357-
"stringUnit" : {
358-
"state" : "translated",
359-
"value" : "The Spezi Framework"
360-
}
361-
}
362-
}
363-
},
364357
"This type of event is currently unsupported. Please contact the developer of this app." : {
365358
"localizations" : {
366359
"en" : {

CS342ExampleApplicationUITests/OnboardingTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ extension XCUIApplication {
100100
buttons["Logout"].tap()
101101
}
102102

103-
XCTAssertTrue(buttons["Signup"].exists)
103+
XCTAssertTrue(buttons["Signup"].waitForExistence(timeout: 2))
104104
buttons["Signup"].tap()
105105

106106

CS342ExampleApplicationUITests/SchedulerTests.swift

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class SchedulerTests: XCTestCase {
2020
app.deleteAndLaunch(withSpringboardAppName: "CS342ExampleApplication")
2121
}
2222

23-
23+
2424
@MainActor
2525
func testScheduler() throws {
2626
let app = XCUIApplication()
@@ -61,6 +61,13 @@ class SchedulerTests: XCTestCase {
6161
XCTAssert(app.staticTexts["E-mail"].exists)
6262
app.staticTexts["E-mail"].tap()
6363

64+
XCTAssert(nextButton.isEnabled)
65+
nextButton.tap()
66+
67+
// staticTexts["What is your e-mail?"] is not exposed in the accessibility hierarchy; it seems like a bug in ResearchKit.
68+
XCTAssert(app.textFields["Tap to answer"].exists)
69+
try app.textFields["Tap to answer"].enter(value: "[email protected]")
70+
6471
XCTAssert(nextButton.isEnabled)
6572
nextButton.tap()
6673

0 commit comments

Comments
 (0)