Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all rest route's functionality #41

Open
paperclover opened this issue Jul 11, 2022 · 4 comments
Open

Test all rest route's functionality #41

paperclover opened this issue Jul 11, 2022 · 4 comments
Assignees
Labels
help wanted i need other people's opinion, skill, and/or knowledge. high priority pkg:rest

Comments

@paperclover
Copy link
Member

At the rest branch we currently are tracking implementation and functionality of the routes, this file specifically.

I will publish a package soon but there's some things I need to finalize first, but if anyone would like to help test route functions by actually writing a code example for them and testing practically with a real token, that would be appreciated. I doubt any routes will fail and if the types were wrong, that's on discord-api-types and not us.

@paperclover paperclover added high priority pkg:rest help wanted i need other people's opinion, skill, and/or knowledge. labels Jul 11, 2022
@Hycord Hycord self-assigned this Jul 11, 2022
@Hycord
Copy link
Contributor

Hycord commented Jul 11, 2022

I am testing every endpoint before I check it off in routes.md

@Hycord
Copy link
Contributor

Hycord commented Jul 11, 2022

As outlined in that file, everyone should ensure full functionality of all endpoints before they get checked off. However it wouldn't be a bad idea to set up a file that will run through all API routes and test every one of them all at once. Opinions on setting this up?

@paperclover
Copy link
Member Author

However it wouldn't be a bad idea to set up a file that will run through all API routes and test every one of them all at once. Opinions on setting this up?

i thought about that, and it would be extremely cool if we could pull off unit tests for the rest api, but that just seems like a huge task to me. maybe it isn't; and if we did do it, we would have a cool line of saying "unit tested against the api". maybe re-look into it once bun's fetch/event loop bug gets fixed, and we can use bun's testing utils or just a standalone program in a test folder or something.

@Hycord
Copy link
Contributor

Hycord commented Jul 11, 2022

Yeah. Will look into this later.

@paperclover paperclover modified the milestone: post 2.0 Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted i need other people's opinion, skill, and/or knowledge. high priority pkg:rest
Projects
None yet
Development

No branches or pull requests

2 participants