Abs none #794
Open
Abs none #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnaceBleukx
reviewed
Dec 2, 2025
Collaborator
IgnaceBleukx
left a comment
IgnaceBleukx
left a comment
There was a problem hiding this comment.
Nice catch, I suppose this is can actually happen for all of our globals?
We should check this explicitly when calling the value of any expression...
We currently do it for some but not all... Not all will actually return an error, but the value could be wrong...
E.g., for alldifferent, we check the value as len(set(argvals)) == len(self.args), so if there is one argument that has value None, this check will still be valid...
I you want to go through the other globals fixing it similarly to this one, that would be great, but otherwise fine to just open an issue for that and merge this already : )
| self.x[0]._value = 0 | ||
| self.assertEqual(gt.value(), 0) | ||
| self.x[0]._value = None | ||
| self.assertEqual(gt.value(), None) |
Collaborator
There was a problem hiding this comment.
Better to use assertIsNone here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
.value()on and expression containingabswill currently throw an error if it contains a None. This can occur when a model is UNSAT and one tries to call.value()on one of its expressions afterwards (one containing anabs). Fixed implementation such that theabswill correctly also return None.