Refactor decompose for global functions #793
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Ok so it turned out to be quite some more work that I expected it to be, because of the way we handle objectives, but it should be ready for review now. Currently, the new element decomposition is not the linear-friendly one, as it does not work when the array we're indexing contains integer variables. sum((i == idx) * arr[i]) We can change this easily later now, but first #769 needs to merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed offline, global functions can be decomposed into a numerical value, and some defining constraints.
This PR accomplishes that by removing the
decompose_comparisonfunction we have now.It also massively simplifies the
decompose_in_treecode as there are way fewer cases to check.