Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No explicit warining or exeception throwed when traverse the fields of dataChunk multipe times. #62

Open
NLGithubWP opened this issue Jul 10, 2022 · 1 comment
Assignees
Labels
important need to address soon logic-issue problems about the main logic

Comments

@NLGithubWP
Copy link
Collaborator

NLGithubWP commented Jul 10, 2022

In the readStore, if we traverse one field multiple times, it reads the wrong value and does not throw expectations or warnings.

For example, in RLEInputVector readStore, if we traverse it multiple times with get, the end-offset will prevent the traverse and only return the value in the last offset, which results in a wrong read.

We should either explicitly throws exceptions to prevent multiple traverses, or allow it by removing such constraint or adding reset methods to reset the offset.

@KimballCai
Copy link
Contributor

@NLGithubWP, please refer to this issue when you redesign the engine API

@KimballCai KimballCai added logic-issue problems about the main logic important need to address soon labels Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important need to address soon logic-issue problems about the main logic
Projects
None yet
Development

No branches or pull requests

2 participants