Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to support float format in cohort results #154

Open
KimballCai opened this issue Nov 11, 2024 · 2 comments
Open

need to support float format in cohort results #154

KimballCai opened this issue Nov 11, 2024 · 2 comments

Comments

@KimballCai
Copy link
Contributor

please check the branch support_float_cohort_result

  1. update the unit test in the CohortAnalysisTest.java
  2. check the CohortRet.java incase there is any potential error left
@tinyAdapter
Copy link
Contributor

I think the current implementation is problematic, as it breaks the original behavior and invalidates some tests.

I suggest adding a new entry in the cohort query file (e.g., resultType) with default value INT to make it backward-compatible, while allow users to specify the system to return float values.

@tinyAdapter
Copy link
Contributor

Resolved in #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants