Skip to content

Update the License resolver to return all Licenses#577

Merged
briri merged 3 commits intodevelopmentfrom
feature/all-license-resolver
Jan 26, 2026
Merged

Update the License resolver to return all Licenses#577
briri merged 3 commits intodevelopmentfrom
feature/all-license-resolver

Conversation

@briri
Copy link
Copy Markdown
Collaborator

@briri briri commented Jan 23, 2026 •
edited
Loading

Description

Fixes #1099

Note: this PR is related to the corresponding frontend PR #1130!

Removed pagination and search term from the licenses resolver.

  • Upgraded dmptool/types to 3.1.0 see corresponding PR #22
  • Updated Schema, resolver and model (including unit tests)
  • Added a full set of unit tests for the License resolver

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Added additional unit tests for the resolver. All tests are passing, and manually verified in the Apollo explorer

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I updated the CHANGELOG.md and added documentation if necessary
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@briri briri changed the base branch from main to development January 23, 2026 16:15
briri
briri commented Jan 23, 2026
View reviewed changes
Comment thread src/__mocks__/context.ts
}
}

export const mockResearcherToken = async (): Promise<JWTAccessToken> => {
Copy link
Copy Markdown
Collaborator Author

@briri briri Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added these to facilitate future resolver unit tests

@briri briri requested a review from jupiter007 January 23, 2026 16:17
@briri briri mentioned this pull request Jan 23, 2026
Merged
9 tasks
jupiter007
jupiter007 approved these changes Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jupiter007 jupiter007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread src/resolvers/__tests__/license.spec.ts
@@ -0,0 +1,629 @@
import { ApolloServer } from "@apollo/server";
Copy link
Copy Markdown
Collaborator

@jupiter007 jupiter007 Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jupiter007
Copy link
Copy Markdown
Collaborator

jupiter007 commented Jan 26, 2026

Make sure you update the @dmptool/types version in your package.json

@briri briri merged commit 77682c6 into development Jan 26, 2026
@briri briri deleted the feature/all-license-resolver branch January 26, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jupiter007 jupiter007 jupiter007 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@briri @jupiter007