Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to automate reliable relocking #36

Merged
merged 9 commits into from
Jun 19, 2024

Conversation

mdekstrand
Copy link
Contributor

@mdekstrand mdekstrand commented Jun 19, 2024

This adds a shell script that runs conda-lock with the correct inputs and environment variables to ensure that locking is successful regardless of the user's local Conda configuration. It also tweaks a couple of dependency specifications to make sure that the main category contains a closure (conda-lock is not 100% on achieving that).

Once the upstream conda-lock bug is fixed, we can update this script to add the ability to update only our dependencies.

@mdekstrand mdekstrand requested a review from karlhigley June 19, 2024 15:48
@mdekstrand
Copy link
Contributor Author

This is failing the Docker test, because it does not have the code updates to use the poprox-concepts updates (those are in #35 I think), and the Docker image build does not use locked dependencies.

Once we use lockfiles for Docker image dependencies (which in the current setup would cause both Docker and local tests to fail in #35, not just local), then we'll be in a position where deployment and tests both reliably use the locked dependencies, and are consistent with local development.

@karlhigley karlhigley merged commit 0834957 into main Jun 19, 2024
3 of 4 checks passed
@mdekstrand mdekstrand deleted the mdekstrand/feature/lock-update-script branch June 19, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants