Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ligand charges #6

Open
skfegan opened this issue Sep 14, 2018 · 3 comments
Open

ligand charges #6

skfegan opened this issue Sep 14, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@skfegan
Copy link
Member

skfegan commented Sep 14, 2018

FESetup struggles to get the correct charge for positive and negatively charged ligands. It seems like this can also cause trouble with the complexes.

@skfegan skfegan added the bug Something isn't working label Sep 14, 2018
@edwardclem
Copy link

I'm experiencing this bug as well - I believe it's caused by a bug in pybel with identifying charges in .mol2 files. Converting files to .mol format (with RDKit) has so far resolved this problem for me.

@skfegan
Copy link
Member Author

skfegan commented May 9, 2019

Thanks @edwardclem. If you want to contribute a fix for FESetup, you are welcome to do that. Please submit any pull requests to the dev branch (the master branch is for released versions).

@edwardclem
Copy link

Okay, gotcha! I submitted a bug report to the openbabel devs, seems like charge issues are fairly well known to them. Fixing it through that route seems like the best option to minimize changes to the FESetup code, without adding additional charge-checking code on top of pybel or switching the internal mol processing library from pybel to RDKit, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants