Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Unit Tests #179

Merged
merged 3 commits into from
Mar 11, 2022
Merged

Adding Unit Tests #179

merged 3 commits into from
Mar 11, 2022

Conversation

ashishsingh18
Copy link
Contributor

This PR adds only a few unit tests to get started.

Fix #173

Copy link
Contributor

@AbdulkadirA AbdulkadirA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashishsingh18 Thanks. How should the test be run? Is there CI integration?

@ashishsingh18
Copy link
Contributor Author

@ashishsingh18 Thanks. How should the test be run? Is there CI integration?

@AbdulkadirA This is no CI integration yet. That will be the next step. This can be tested locally by running: pytest --disable-warnings -v from the cmd prompt.

Copy link
Contributor

@AbdulkadirA AbdulkadirA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashishsingh18 Thanks. Some tests fail, but in principle it works.

@AbdulkadirA AbdulkadirA merged commit 037d6d6 into CBICA:main Mar 11, 2022
@AbdulkadirA AbdulkadirA mentioned this pull request Mar 15, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement test
2 participants