Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Params should do comparisons that are case-insensitive #34

Open
water-e opened this issue Jul 20, 2023 · 0 comments
Open

Params should do comparisons that are case-insensitive #34

water-e opened this issue Jul 20, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@water-e
Copy link
Contributor

water-e commented Jul 20, 2023

  • schimpy version: 1.6.x
  • Python version: 3.9

Description

Params are currently loaded in a manner that is case-preserving. This will cause issues with comparisons. Probably fine to preserve comment case, but keys and variables should be .lower()-ed. Good test case would be an echoed file.
@kjnam kjnam added the enhancement New feature or request label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kjnam @water-e