Skip to content

Commit 4c2c4ea

Browse files
committed
Fixing some remaining field validation issues
1 parent 0cd1627 commit 4c2c4ea

File tree

5 files changed

+5
-17
lines changed

5 files changed

+5
-17
lines changed

source-code/app/src/main/java/org/buildmlearn/toolkit/templates/ComprehensionTemplate.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import android.content.DialogInterface;
66
import android.content.Intent;
77
import android.os.Build;
8+
import android.support.v7.app.AlertDialog;
89
import android.view.LayoutInflater;
910
import android.view.View;
1011
import android.widget.BaseAdapter;
@@ -19,7 +20,6 @@
1920
import org.buildmlearn.toolkit.model.TemplateInterface;
2021
import org.buildmlearn.toolkit.utilities.FileDialog;
2122
import org.buildmlearn.toolkit.views.TextViewPlus;
22-
import android.support.v7.app.AlertDialog;
2323
import org.w3c.dom.Document;
2424
import org.w3c.dom.Element;
2525
import org.w3c.dom.NodeList;
@@ -237,6 +237,7 @@ public void onClick(View v) {
237237

238238
for (EditText option : options) {
239239
if ("".equals(option.getText().toString().trim())){
240+
option.setText("");
240241
continue;
241242
}
242243
if (option.getText().toString()!= null && "".equals(option.getText().toString().trim())) {
@@ -467,6 +468,7 @@ public void onClick(View v) {
467468

468469
for (EditText option : options) {
469470
if ("".equals(option.getText().toString().trim())){
471+
option.setText("");
470472
continue;
471473
}
472474
if (option.getText().toString()!= null && "".equals(option.getText().toString().trim())) {

source-code/app/src/main/java/org/buildmlearn/toolkit/templates/InfoTemplate.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
import android.view.View;
1010
import android.widget.BaseAdapter;
1111
import android.widget.EditText;
12-
import android.widget.Toast;
13-
1412

1513
import org.buildmlearn.toolkit.R;
1614
import org.buildmlearn.toolkit.infotemplate.fragment.SplashFragment;
@@ -47,9 +45,6 @@ public static boolean validated(Context context, EditText word, EditText meaning
4745
if ("".equals(wordText)) {
4846
word.setError(context.getString(R.string.enter_word));
4947
return false;
50-
} else if (!wordText.matches("([A-Za-z ]+)")){
51-
word.setError(context.getString(R.string.enter_valid_word));
52-
return false;
5348
} else if ("".equals(meaningText)) {
5449
meaning.setError(context.getString(R.string.enter_description));
5550
return false;

source-code/app/src/main/java/org/buildmlearn/toolkit/templates/LearnSpellingTemplate.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
import android.view.View;
1010
import android.widget.BaseAdapter;
1111
import android.widget.EditText;
12-
import android.widget.Toast;
13-
1412

1513
import org.buildmlearn.toolkit.R;
1614
import org.buildmlearn.toolkit.learnspelling.fragment.SplashFragment;
@@ -47,15 +45,9 @@ private static boolean validated(Context context, EditText word, EditText meanin
4745
if ("".equals(wordText)) {
4846
word.setError(context.getString(R.string.enter_word));
4947
return false;
50-
} else if (!wordText.matches("([A-Za-z ]+)")){
51-
word.setError(context.getString(R.string.enter_valid_word));
52-
return false;
5348
} else if ("".equals(meaningText)) {
5449
meaning.setError(context.getString(R.string.enter_meaning));
5550
return false;
56-
} else if(!meaningText.matches("([A-Za-z ]+)")){
57-
meaning.setError(context.getString(R.string.enter_valid_meaning));
58-
return false;
5951
}
6052
return true;
6153

source-code/app/src/main/java/org/buildmlearn/toolkit/templates/QuizTemplate.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import android.widget.RadioButton;
1313
import android.widget.Toast;
1414

15-
1615
import org.buildmlearn.toolkit.R;
1716
import org.buildmlearn.toolkit.model.Template;
1817
import org.buildmlearn.toolkit.model.TemplateInterface;
@@ -173,6 +172,7 @@ public void onClick(View v) {
173172
}
174173
for (EditText option : options) {
175174
if ("".equals(option.getText().toString().trim())){
175+
option.setText("");
176176
continue;
177177
}
178178
if (option.getText().toString()!= null && "".equals(option.getText().toString().trim())) {
@@ -295,6 +295,7 @@ public void onClick(View v) {
295295

296296
for (EditText option : options) {
297297
if ("".equals(option.getText().toString().trim())){
298+
option.setText("");
298299
continue;
299300
}
300301
if (option.getText().toString()!= null && "".equals(option.getText().toString().trim())) {

source-code/app/src/main/java/org/buildmlearn/toolkit/templates/VideoCollectionTemplate.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@ private static boolean validated(Context context, EditText link) {
7171
if ("".equals(linkText)) {
7272
link.setError(context.getString(R.string.video_collection_template_link_hint));
7373
return false;
74-
} else if(!Patterns.WEB_URL.matcher(linkText).matches()){
75-
link.setError(context.getString(R.string.video_collection_template_link_valid_hint));
7674
} else if (!(linkText.contains(YOUTUBE + ".com") || linkText.contains(YOUTUBE_SHORT) || linkText.contains(DAILYMOTION + ".com") || linkText.contains(VIMEO + ".com"))) {
7775
link.setError(context.getString(R.string.video_collection_template_linited_links));
7876
return false;

0 commit comments

Comments
 (0)