Fixed Text Validation in SettingsFragment

Author: opticod

source-code/app/src/main/java/org/buildmlearn/toolkit/fragment/SettingsFragment.java

@@ -2,6 +2,7 @@
 
 import android.app.Activity;
 import android.app.ProgressDialog;
+import android.content.Context;
 import android.content.DialogInterface;
 import android.content.Intent;
 import android.content.SharedPreferences;
@@ -12,7 +13,6 @@
 import android.preference.PreferenceFragment;
 import android.preference.PreferenceManager;
 import android.support.v7.app.AlertDialog;
-import android.text.TextUtils;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.widget.EditText;
@@ -116,27 +116,47 @@ public void resetUserName() {
         View dialogView = inflater.inflate(R.layout.dialog_settings_your_name, null);
         final EditText editInput = (EditText) dialogView.findViewById(R.id.et_dialog_settings_your_name);
         editInput.setText(prefUsername.getSummary());
+
         final AlertDialog dialog =
                 new AlertDialog.Builder(getActivity())
                         .setTitle(R.string.title_user_name)
                         .setView(dialogView)
                         .setNegativeButton(R.string.dialog_no, null)
-                        .setPositiveButton(R.string.dialog_yes, new DialogInterface.OnClickListener() {
-                            @Override
-                            public void onClick(DialogInterface dialog, int which) {
-                                String enteredName = editInput.getText().toString();
-                                if (TextUtils.isEmpty(enteredName) || enteredName == null || !Character.isLetterOrDigit(((String) enteredName).charAt(0))) {
-                                    Toast.makeText(getActivity(), R.string.valid_msg_name,Toast.LENGTH_LONG).show();
-                                }
-                                else {
-                                    prefUsername.getEditor().putString(getString(R.string.key_user_name), enteredName).commit();
-                                    prefUsername.setSummary(editInput.getText().toString());
-                                    dialog.dismiss();
-                                }
+                        .setPositiveButton(R.string.dialog_yes, null).create();
 
-                            }
-                        }).create();
         dialog.show();
+
+        dialog.getButton(DialogInterface.BUTTON_POSITIVE).setOnClickListener(new View.OnClickListener() {
+            @Override
+            public void onClick(View v) {
+
+                if (validated(editInput)) {
+                    String enteredName = editInput.getText().toString();
+                    prefUsername.getEditor().putString(getString(R.string.key_user_name), enteredName).commit();
+                    prefUsername.setSummary(editInput.getText().toString());
+                    dialog.dismiss();
+                }
+
+            }
+        });
+    }
+
+    private boolean validated(EditText editInput) {
+        if (editInput == null) {
+            return false;
+        }
+
+        String authorText = editInput.getText().toString().trim();
+        Context mContext = getActivity();
+
+        if ("".equals(authorText)) {
+            editInput.setError(mContext.getString(R.string.valid_msg_name));
+            return false;
+        } else if (!Character.isLetterOrDigit(authorText.charAt(0))) {
+            editInput.setError(mContext.getString(R.string.title_valid));
+            return false;
+        }
+        return true;
     }
 
     @Override