fix[gen1][core] ENG-7515 add query.id when hitting content API for symbols #3752
+97
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clyde-builderio
requested review from
mrkoreye
and removed request for
a team
🦋 Changeset detectedLatest commit: 0616543 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
samijaber
reviewed
Nov 20, 2024
packages/core/src/builder.class.ts
Outdated
Comment on lines
2636
to
2639
| if (apiEndpoint === 'content' && queue[0].model === 'symbol') { | ||
| queryParams['query.id'] = queue[0].entry; | ||
| } | ||
|
|
There was a problem hiding this comment.
We should set this in Symbol.tsx instead. I think it can go in here:
builder/packages/react/src/blocks/Symbol.tsx
Lines 159 to 165 in bff6858
The reason for that is because the model name might be something other than symbol
There was a problem hiding this comment.
The change is working as expected. Here is a loom with a demo of the changes https://www.loom.com/share/083d6711f94048ce8b88c514c71012e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Gen1 SDK, when content API is hit for Symbols, it does not render symbols properly
Jira ticket
https://builder-io.atlassian.net/browse/ENG-7515
Loom
https://www.loom.com/share/90d3b6e317bb493e98ad418ac2f0b7a0