Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add visual editing tests for columns in gen1 sdk #3714

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sidmohanty11
Copy link
Contributor

Description

Add a short description of what changes you made, why you made them, and any other context that you think might be helpful for someone to better understand what is contained in this pull request. This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.

Screenshot
If relevant, add a screenshot or two of the changes you made.

Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: 6010bcf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samijaber
Copy link
Contributor

did this end up not being needed?

@sidmohanty11
Copy link
Contributor Author

@samijaber with my investigation found out that the patch replace didn't work for paths containing /children/* not sure why though. Let me reopen this PR, will create a new content for testing

@sidmohanty11 sidmohanty11 reopened this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants