From bf2b4281f95360c4e8fabfed9fb8f42e101399ed Mon Sep 17 00:00:00 2001
From: aaronvg <aaron@boundaryml.com>
Date: Mon, 4 Nov 2024 14:16:54 -0800
Subject: [PATCH] add tracing_subscriber needed rust flags for each binding
 (#1143)

<!-- ELLIPSIS_HIDDEN -->


> [!IMPORTANT]
> Add Rust flags for `tracing_subscriber` and update GitHub workflows to
include `aaron-fix` branch for Python, Ruby, and TypeScript clients.
>
>   - **Rust Configuration**:
> - Add `rustflags` for `tracing_unstable` in `.cargo/config.toml` for
Python, Ruby, and TypeScript clients.
> - Include musl target-specific flags in each language client's
configuration.
>   - **GitHub Workflows**:
> - Add `aaron-fix` branch to trigger builds in
`build-python-release.reusable.yaml`,
`build-ruby-release.reusable.yaml`, and
`build-typescript-release.reusable.yaml`.
> - Set `RUSTFLAGS` in `build-ruby-release.reusable.yaml` and
`build-typescript-release.reusable.yaml` for musl targets.
>   - **Ruby Extension**:
>     - Add `extra_rustflags` for `tracing_unstable` in `extconf.rb`.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis"
src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=BoundaryML%2Fbaml&utm_source=github&utm_medium=referral)<sup>
for c72c2f6a1955f927d8228fee379c157b2bec6a3e. It will automatically
update as commits are pushed.</sup>


<!-- ELLIPSIS_HIDDEN -->
---
 .github/workflows/build-python-release.reusable.yaml |  8 ++++----
 .github/workflows/build-ruby-release.reusable.yaml   |  5 +++++
 .../workflows/build-typescript-release.reusable.yaml | 12 ++++++++----
 engine/language_client_ruby/ext/ruby_ffi/extconf.rb  |  1 +
 4 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/build-python-release.reusable.yaml b/.github/workflows/build-python-release.reusable.yaml
index a394d76cf..89caa920c 100644
--- a/.github/workflows/build-python-release.reusable.yaml
+++ b/.github/workflows/build-python-release.reusable.yaml
@@ -3,7 +3,7 @@ name: Release language_client_python
 on:
   workflow_call: {}
   push:
-    branches: [manylinux-x86]
+    branches: [manylinux-x86, aaron-fix]
 
 concurrency:
   # suffix is important to prevent a concurrency deadlock with the calling workflow
@@ -44,13 +44,13 @@ jobs:
 
           - target: x86_64-apple-darwin
             runs_on: macos-latest
-            
+
           - target: aarch64-apple-darwin
             runs_on: macos-latest
-            
+
           - target: x86_64-pc-windows-msvc
             runs_on: windows-latest
-            
+
     name: ${{ matrix._.target }}
     runs-on: ${{ matrix._.runs_on }}
     steps:
diff --git a/.github/workflows/build-ruby-release.reusable.yaml b/.github/workflows/build-ruby-release.reusable.yaml
index 4fb67210b..055512b65 100644
--- a/.github/workflows/build-ruby-release.reusable.yaml
+++ b/.github/workflows/build-ruby-release.reusable.yaml
@@ -2,6 +2,8 @@ name: Release engine/language_client_ruby
 
 on:
   workflow_call: {}
+  push:
+    branches: [aaron-fix]
 
 permissions:
   contents: read
@@ -72,6 +74,9 @@ jobs:
           mkdir -p "$rb_sys_dock_cache_dir"
           echo "RB_SYS_DOCK_CACHE_DIR=$rb_sys_dock_cache_dir" >> $GITHUB_ENV
           echo "rb_sys_version=$rb_sys_version" >> $GITHUB_OUTPUT
+          cat >>$GITHUB_ENV <<EOF
+          RUSTFLAGS=--cfg tracing_unstable
+          EOF
 
       - name: Setup rb-sys
         shell: bash
diff --git a/.github/workflows/build-typescript-release.reusable.yaml b/.github/workflows/build-typescript-release.reusable.yaml
index 213d3f88a..8df43c8da 100644
--- a/.github/workflows/build-typescript-release.reusable.yaml
+++ b/.github/workflows/build-typescript-release.reusable.yaml
@@ -3,7 +3,7 @@ name: Release language_client_typescript
 on:
   workflow_call: {}
   push:
-    branches: [sam/alpine-warnings]
+    branches: [sam/alpine-warnings, aaron-fix]
 
 concurrency:
   # suffix is important to prevent a concurrency deadlock with the calling workflow
@@ -57,6 +57,7 @@ jobs:
               CC_x86_64_unknown_linux_musl=x86_64-linux-musl-gcc
               CXX_x86_64_unknown_linux_musl=x86_64-linux-musl-g++
               AR_x86_64_unknown_linux_musl=x86_64-linux-musl-ar
+              RUSTFLAGS=-C target-feature=-crt-static --cfg tracing_unstable
               EOF
             node_build: pnpm build:napi-release --target x86_64-unknown-linux-musl --use-napi-cross
 
@@ -66,6 +67,9 @@ jobs:
               curl -LO https://musl.cc/aarch64-linux-musl-cross.tgz
               tar -xzf aarch64-linux-musl-cross.tgz
               echo "$PWD/aarch64-linux-musl-cross/bin" >> $GITHUB_PATH
+              cat >>$GITHUB_ENV <<EOF
+              RUSTFLAGS=-C target-feature=-crt-static --cfg tracing_unstable
+              EOF
             node_build: pnpm build:napi-release --target aarch64-unknown-linux-musl --use-napi-cross
 
     name: ${{ matrix._.target }}
@@ -101,7 +105,7 @@ jobs:
       - name: PNPM Install
         run: pnpm install --frozen-lockfile
         working-directory: engine/language_client_typescript
-      
+
       # per-matrix-entry dependency setup
       - name: Build tools setup
         run: ${{ matrix._.before }}
@@ -110,7 +114,7 @@ jobs:
       - name: PNPM Build
         run: ${{ matrix._.node_build }}
         working-directory: engine/language_client_typescript
-      
+
       - name: Build TS
         run: pnpm build:ts_build
         working-directory: engine/language_client_typescript
@@ -120,4 +124,4 @@ jobs:
         with:
           name: bindings-${{ matrix._.target }}
           path: engine/language_client_typescript/*.node
-          if-no-files-found: error
\ No newline at end of file
+          if-no-files-found: error
diff --git a/engine/language_client_ruby/ext/ruby_ffi/extconf.rb b/engine/language_client_ruby/ext/ruby_ffi/extconf.rb
index fb30ef854..0f497583e 100644
--- a/engine/language_client_ruby/ext/ruby_ffi/extconf.rb
+++ b/engine/language_client_ruby/ext/ruby_ffi/extconf.rb
@@ -10,6 +10,7 @@
 #    - GEM_NAME is the name of the gem in ext/baml
 create_rust_makefile("ruby_ffi") do |r|
   r.extra_cargo_args += ["--package", "ruby_ffi"]
+  r.extra_rustflags = ["--cfg=tracing_unstable"]
   r.env = {
     "MACOSX_DEPLOYMENT_TARGET" => "10.13",
   }